From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-serial@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Jong-Sung Kim <neidhard.kim@lge.com>,
stable <stable@vger.kernel.org>,
Chanho Min <chanho0207@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
Subject: Re: [PATCH] serial: PL011: move interrupt clearing
Date: Thu, 29 Mar 2012 14:33:33 -0700 [thread overview]
Message-ID: <20120329213333.GA15231@kroah.com> (raw)
In-Reply-To: <CACxGe6u+KeYzWwiJ7MK7pWG444Y99CQ1LLCZP4m3R=zdYFR_pg@mail.gmail.com>
On Thu, Mar 29, 2012 at 02:49:37PM -0600, Grant Likely wrote:
> On Wed, Mar 21, 2012 at 1:15 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > Commit 360f748b204275229f8398cb2f9f53955db1503b
> > "serial: PL011: clear pending interrupts"
> > attempts to clear interrupts by writing to a
> > yet-unassigned memory address. This fixes the issue.
> >
> > The breaking patch is marked for stable so should be
> > carried along with the other patch.
> >
> > Cc: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: stable <stable@vger.kernel.org>
> > Reported-by: Viresh Kumar <viresh.kumar@st.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Ugh; the original patch is obviously broken. How did it get applied
> without testing?
>
> Greg, can you get this out to Linus ASAP please? I have one comment
> below, but I don't think it should block merging this patch.
>
> Tested-by: Grant Likely <grant.likely@secretlab.ca>
Thanks, I'll get it to him after 3.4-rc1 is out, in a few days, along
with other tty fixes being queued up.
greg k-h
next prev parent reply other threads:[~2012-03-29 21:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 19:15 [PATCH] serial: PL011: move interrupt clearing Linus Walleij
2012-03-22 1:04 ` viresh kumar
2012-03-22 8:00 ` Linus Walleij
2012-03-23 3:39 ` viresh kumar
2012-03-23 8:17 ` Linus Walleij
2012-03-29 20:49 ` Grant Likely
2012-03-29 21:22 ` Linus Walleij
2012-03-29 21:33 ` Greg Kroah-Hartman [this message]
2012-04-03 15:36 ` Paul Gortmaker
2012-04-03 16:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329213333.GA15231@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chanho0207@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=neidhard.kim@lge.com \
--cc=shreshthakumar.sahu@stericsson.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox