From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] serial: samsung: Fixed wrong comparison for baudclk_rate Date: Tue, 15 May 2012 11:15:41 +0100 Message-ID: <20120515101541.GH10453@n2100.arm.linux.org.uk> References: <000101cd3283$5f58eba0$1e0ac2e0$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:55363 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426Ab2EOKPz (ORCPT ); Tue, 15 May 2012 06:15:55 -0400 Content-Disposition: inline In-Reply-To: <000101cd3283$5f58eba0$1e0ac2e0$%kim@samsung.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Kyoungil Kim Cc: linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Kukjin Kim' , 'Yoon' , 'Alan Cox' On Tue, May 15, 2012 at 07:13:28PM +0900, Kyoungil Kim wrote: > port->baudclk_rate should be compared to the rate of port->baudclk, > because port->baudclk_rate was assigned as the rate of port->baudclk previously. > So to check that the current baudclk rate is same as previous rate, > the target of comparison sholud be the rate of port->baudclk. > > Signed-off-by: Jun-Ho, Yoon > Signed-off-by: Kyoungil Kim > --- > drivers/tty/serial/samsung.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > index d8b0aee..c4867ea 100644 > --- a/drivers/tty/serial/samsung.c > +++ b/drivers/tty/serial/samsung.c > @@ -1014,10 +1014,10 @@ static int s3c24xx_serial_cpufreq_transition(struct notifier_block *nb, > * a disturbance in the clock-rate over the change. > */ > > - if (IS_ERR(port->clk)) > + if (IS_ERR_OR_NULL(port->baudclk)) NAK. See my previous emails on the validity of clk_get() return values.