public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/tty_io.c: fix a potential memleak at do_tty_write()
Date: Mon, 18 Jun 2012 08:26:42 -0700	[thread overview]
Message-ID: <20120618152642.GB15267@kroah.com> (raw)
In-Reply-To: <4FDF1DDA.3030704@oracle.com>

On Mon, Jun 18, 2012 at 08:23:54PM +0800, Jeff Liu wrote:
> Hello,
> 
> Looks there is a potential memory leak at drivers/tty/tty_io.c: do_tty_write().
> It did allocate a buf_chunk if tty->write_cnt < chunk, however, buf_chunk was not
> freed after the writing is done.  Below tiny patch could fix it.
> 
> Thanks,
> -Jeff
> 

Thanks for the patch, but can you resend it with a signed-off-by: line
as described in Documentation/SubmittingPatches so that we can properly
apply the patch?

thanks,

greg k-h

  reply	other threads:[~2012-06-18 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 12:23 [PATCH] drivers/tty/tty_io.c: fix a potential memleak at do_tty_write() Jeff Liu
2012-06-18 15:26 ` Greg KH [this message]
2012-06-18 16:04 ` Alan Cox
2012-06-18 18:00   ` Paul Fulghum
2012-06-19  3:44     ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120618152642.GB15267@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jeff.liu@oracle.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox