From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: greg@kroah.com, linux-serial@vger.kernel.org
Subject: [PATCH 05/12] usb, kobil: Sort out some bogus tty handling
Date: Wed, 27 Jun 2012 12:21:54 +0100 [thread overview]
Message-ID: <20120627112152.5678.49318.stgit@localhost.localdomain> (raw)
In-Reply-To: <20120627112102.5678.4141.stgit@localhost.localdomain>
From: Alan Cox <alan@linux.intel.com>
Stuff noticed while doing the termios conversion.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/usb/serial/kobil_sct.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index fafeabb..0852472 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -192,8 +192,8 @@ static void kobil_init_termios(struct tty_struct *tty)
{
/* Default to echo off and other sane device settings */
tty->termios->c_lflag = 0;
- tty->termios->c_lflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE);
- tty->termios->c_iflag = IGNBRK | IGNPAR | IXOFF;
+ tty->termios->c_iflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE);
+ tty->termios->c_iflag |= IGNBRK | IGNPAR | IXOFF;
/* do NOT translate CR to CR-NL (0x0A -> 0x0A 0x0D) */
tty->termios->c_oflag &= ~ONLCR;
}
@@ -588,7 +588,7 @@ static void kobil_set_termios(struct tty_struct *tty,
if (priv->device_type == KOBIL_USBTWIN_PRODUCT_ID ||
priv->device_type == KOBIL_KAAN_SIM_PRODUCT_ID) {
/* This device doesn't support ioctl calls */
- *tty->termios = *old;
+ tty_termios_copy_hw(tty->termios, old_termios);
return;
}
next prev parent reply other threads:[~2012-06-27 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 11:21 [PATCH 01/12] f81232: correct stubbed termios handler Alan Cox
2012-06-27 11:21 ` [PATCH 02/12] usb: fix sillies in the metro USB driver Alan Cox
2012-06-27 11:21 ` [PATCH 03/12] tty: Note n_tty race Alan Cox
2012-06-27 11:21 ` [PATCH 04/12] gpio-sch: Fix leak of resource Alan Cox
2012-06-27 19:32 ` Greg KH
2012-06-27 11:21 ` Alan Cox [this message]
2012-06-27 11:22 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 22:39 ` Paul Gortmaker
2012-06-27 22:50 ` Alan Cox
2012-06-27 11:22 ` [PATCH 07/12] 8250: propogate the bugs field Alan Cox
2012-06-27 11:22 ` [PATCH 08/12] 8250: add support for ASIX devices with a FIFO bug Alan Cox
2012-06-27 11:22 ` [PATCH 10/12] tty: tidy up the RESET_TERMIOS case Alan Cox
2012-06-27 11:23 ` [PATCH 11/12] vt: fix the keyboard/led locking Alan Cox
2012-06-27 11:23 ` [PATCH 12/12] tty: Move the handling of the tty release logic Alan Cox
2012-06-27 19:35 ` [PATCH 01/12] f81232: correct stubbed termios handler Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-07-14 14:30 [PATCH 00/12] tty: take 3 - termios, locking and 8250 bugs Alan Cox
2012-07-14 14:32 ` [PATCH 05/12] usb, kobil: Sort out some bogus tty handling Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627112152.5678.49318.stgit@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).