* [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling [not found] <1340740469-31445-1-git-send-email-paul.gortmaker@windriver.com> @ 2012-06-26 19:54 ` Paul Gortmaker 2012-06-27 11:52 ` Alan Cox 0 siblings, 1 reply; 4+ messages in thread From: Paul Gortmaker @ 2012-06-26 19:54 UTC (permalink / raw) To: benh Cc: linuxppc-dev, Paul Gortmaker, Alan Cox, Greg Kroah-Hartman, linux-serial We've are dropping the support for the EOL SBC8560, so we can also delete this variant of the Alpha quirk support. Cc: Alan Cox <alan@linux.intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-serial@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/tty/serial/8250/8250.h | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h index f9719d1..ffd1e6e 100644 --- a/drivers/tty/serial/8250/8250.h +++ b/drivers/tty/serial/8250/8250.h @@ -119,13 +119,6 @@ static inline void serial_dl_write(struct uart_8250_port *up, int value) * is cleared, the machine locks up with endless interrupts. */ #define ALPHA_KLUDGE_MCR (UART_MCR_OUT2 | UART_MCR_OUT1) -#elif defined(CONFIG_SBC8560) -/* - * WindRiver did something similarly broken on their SBC8560 board. The - * UART tristates its IRQ output while OUT2 is clear, but they pulled - * the interrupt line _up_ instead of down, so if we register the IRQ - * while the UART is in that state, we die in an IRQ storm. */ -#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2) #else #define ALPHA_KLUDGE_MCR 0 #endif -- 1.7.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling 2012-06-26 19:54 ` [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling Paul Gortmaker @ 2012-06-27 11:52 ` Alan Cox 2012-06-27 14:04 ` Paul Gortmaker 0 siblings, 1 reply; 4+ messages in thread From: Alan Cox @ 2012-06-27 11:52 UTC (permalink / raw) To: Paul Gortmaker Cc: benh, linuxppc-dev, Alan Cox, Greg Kroah-Hartman, linux-serial On Tue, 26 Jun 2012 15:54:29 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > We've are dropping the support for the EOL SBC8560, so we can > also delete this variant of the Alpha quirk support. > > Cc: Alan Cox <alan@linux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-serial@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/tty/serial/8250/8250.h | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h > index f9719d1..ffd1e6e 100644 > --- a/drivers/tty/serial/8250/8250.h > +++ b/drivers/tty/serial/8250/8250.h > @@ -119,13 +119,6 @@ static inline void serial_dl_write(struct uart_8250_port *up, int value) > * is cleared, the machine locks up with endless interrupts. > */ > #define ALPHA_KLUDGE_MCR (UART_MCR_OUT2 | UART_MCR_OUT1) > -#elif defined(CONFIG_SBC8560) > -/* > - * WindRiver did something similarly broken on their SBC8560 board. The > - * UART tristates its IRQ output while OUT2 is clear, but they pulled > - * the interrupt line _up_ instead of down, so if we register the IRQ > - * while the UART is in that state, we die in an IRQ storm. */ > -#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2) > #else > #define ALPHA_KLUDGE_MCR 0 > #endif Would you mind removing all of the crap from this if its going (eg 8250.c) not just the header so it gets missed ? Kill the symbol entirely ? Alan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling 2012-06-27 11:52 ` Alan Cox @ 2012-06-27 14:04 ` Paul Gortmaker 2012-06-27 14:37 ` Alan Cox 0 siblings, 1 reply; 4+ messages in thread From: Paul Gortmaker @ 2012-06-27 14:04 UTC (permalink / raw) To: Alan Cox; +Cc: benh, linuxppc-dev, Alan Cox, Greg Kroah-Hartman, linux-serial On 12-06-27 07:52 AM, Alan Cox wrote: > On Tue, 26 Jun 2012 15:54:29 -0400 > Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > >> We've are dropping the support for the EOL SBC8560, so we can >> also delete this variant of the Alpha quirk support. >> >> Cc: Alan Cox <alan@linux.intel.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: linux-serial@vger.kernel.org >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> --- >> drivers/tty/serial/8250/8250.h | 7 ------- >> 1 files changed, 0 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h >> index f9719d1..ffd1e6e 100644 >> --- a/drivers/tty/serial/8250/8250.h >> +++ b/drivers/tty/serial/8250/8250.h >> @@ -119,13 +119,6 @@ static inline void serial_dl_write(struct uart_8250_port *up, int value) >> * is cleared, the machine locks up with endless interrupts. >> */ >> #define ALPHA_KLUDGE_MCR (UART_MCR_OUT2 | UART_MCR_OUT1) >> -#elif defined(CONFIG_SBC8560) >> -/* >> - * WindRiver did something similarly broken on their SBC8560 board. The >> - * UART tristates its IRQ output while OUT2 is clear, but they pulled >> - * the interrupt line _up_ instead of down, so if we register the IRQ >> - * while the UART is in that state, we die in an IRQ storm. */ >> -#define ALPHA_KLUDGE_MCR (UART_MCR_OUT2) >> #else >> #define ALPHA_KLUDGE_MCR 0 >> #endif > > Would you mind removing all of the crap from this if its going (eg > 8250.c) not just the header so it gets missed ? Kill the symbol entirely ? I will, once Alpha is removed from the tree. At the moment, it still uses it. Paul. -- > > Alan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling 2012-06-27 14:04 ` Paul Gortmaker @ 2012-06-27 14:37 ` Alan Cox 0 siblings, 0 replies; 4+ messages in thread From: Alan Cox @ 2012-06-27 14:37 UTC (permalink / raw) To: Paul Gortmaker Cc: benh, linuxppc-dev, Alan Cox, Greg Kroah-Hartman, linux-serial > I will, once Alpha is removed from the tree. At the moment, > it still uses it. Ok I hadn't realised that. Alan ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-27 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1340740469-31445-1-git-send-email-paul.gortmaker@windriver.com>
2012-06-26 19:54 ` [PATCH 3/3] serial/8250: delete WR SBC850 UART quirk handling Paul Gortmaker
2012-06-27 11:52 ` Alan Cox
2012-06-27 14:04 ` Paul Gortmaker
2012-06-27 14:37 ` Alan Cox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox