From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 1/2] Add a new helper for sleepable BTM acquirements which is used by tty_write_message() Date: Sat, 30 Jun 2012 13:35:49 +0100 Message-ID: <20120630133549.2431968e@pyramind.ukuu.org.uk> References: <4FEEC96E.9070502@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FEEC96E.9070502@oracle.com> Sender: linux-ext4-owner@vger.kernel.org To: jeff.liu@oracle.com Cc: linux-serial@vger.kernel.org, "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , gregkh@linuxfoundation.org, Jan Kara , Ted Ts'o List-Id: linux-serial@vger.kernel.org On Sat, 30 Jun 2012 17:39:58 +0800 Jeff Liu wrote: > This helper only used by tty_write_message(), it will sleep until BTM lock acquired. This makes no sense at all. mutexes already sleep. Your code is also wrong for real time processes. So NAK.