From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Aras Vaichas <aras.vaichas@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: can't detect 16550A at port 0x010 on Vortex86dx board
Date: Mon, 9 Jul 2012 16:52:17 +0100 [thread overview]
Message-ID: <20120709165217.63e983b7@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAJkQPOmBQPejYxa7=nW6pczCP+soYgLCxhuGHQMg3MjO0aZVmQ@mail.gmail.com>
> CONFIG_SERIAL_8250_SHARE_IRQ=y
>
> It needed IRQ sharing to make it work.
Fair enough, that's usually set.
> COM9 on a Vortex86DX is now working in Linux 3.3.8 but it requires
> more than a simple serial driver patch.
>
> I'm not entirely sure how to go about creating a proper patch for the
> changes I have made. My serial driver writes to the South Bridge, but
> it's a quick hack using outl() calls to the right addresses. Should I
> use a proper PCI function call?
If the Southbridge is a PCI device then yes.
> I also modified the x86 io port mappings in /arch/x86/kernel/setup.c.
> Do I either add #ifdef-ery to setup.c, or create a new entry in
> arch/x86/kernel/cpu/ and do my different io mappings there?
ifdeffery is bad. New cpu type is preferable. If the differences are
trivial then some kind of runtime handling is even better.
What you could do is post the hack patch with the questions attached -
not as a proposed kernel patch but as a "what is needed" guide so we can
work out the best way to do it.
Alan
prev parent reply other threads:[~2012-07-09 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 21:00 can't detect 16550A at port 0x010 on Vortex86dx board Aras Vaichas
2012-07-06 22:54 ` Alan Cox
2012-07-09 12:42 ` Aras Vaichas
2012-07-09 15:15 ` Aras Vaichas
2012-07-09 15:52 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709165217.63e983b7@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=aras.vaichas@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox