From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Landley <rob@landley.net>,
devicetree-discuss@lists.ozlabs.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: of_serial: add no-loopback-test property
Date: Sat, 14 Jul 2012 15:01:01 +0100 [thread overview]
Message-ID: <20120714150101.1810c829@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1342267580-3672-1-git-send-email-juhosg@openwrt.org>
On Sat, 14 Jul 2012 14:06:20 +0200
Gabor Juhos <juhosg@openwrt.org> wrote:
> The loopback test mode is not implemented in all
> NS16550 compatible UARTs. The 8250 driver uses the
> UPF_SKIP_TEST flag to indicate this, however it is
> not possible to set this flag via device-tree.
>
> Add a new 'no-loopback-test' property, and modify
> the of_serial driver to set the UPF_SKIP_TEST flag
> if the property is present.
>
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Looks good to me but clashes with the sync of the termios changes, which
we urgently need to get in first.
Greg - I'll add this to my patch stack with the relevant changes so that
it doesn't get messed up.
Alan
next prev parent reply other threads:[~2012-07-14 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 12:06 [PATCH] tty: of_serial: add no-loopback-test property Gabor Juhos
2012-07-14 14:01 ` Alan Cox [this message]
2012-07-14 14:04 ` Greg Kroah-Hartman
2012-07-14 15:41 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120714150101.1810c829@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=juhosg@openwrt.org \
--cc=linux-serial@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox