From: Alexander Shiyan <shc_work@mail.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] serial: sc26xx: Fix compile breakage
Date: Wed, 1 Aug 2012 21:44:16 +0400 [thread overview]
Message-ID: <20120801214416.36e82420.shc_work@mail.ru> (raw)
In-Reply-To: <20120801150440.GA20956@kroah.com>
On Wed, 1 Aug 2012 08:04:40 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Wed, Aug 01, 2012 at 06:55:30PM +0400, Alexander Shiyan wrote:
> > Wed, 1 Aug 2012 05:56:37 -0700 от Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > > On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:
> > > > This patch fixes the following compile breakage:
> > > > CC drivers/tty/serial/sc26xx.o
> > > > drivers/tty/serial/sc26xx.c: In function 'read_sc_port':
> > > > drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb'
> > > > drivers/tty/serial/sc26xx.c: In function 'write_sc_port':
> > > > drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb'
> > > > drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe':
> > > > drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache'
> > > > drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast
> > > > make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1
> > > > make[2]: *** [drivers/tty/serial] Error 2
> > > > make[1]: *** [drivers/tty] Error 2
> > > > make: *** [drivers] Error 2
> > >
> > > Breakage in what tree? What caused this to break?
> > Breakage due to missing header linux/io.h.
>
> Again, where did this break (3.4, 3.5, 3.6-rc1, 2.6.32, etc.) and what
> caused it to break (what patch?)
I'm using kernel 3.4.5. Perhaps, the problem not in header that missing, but is that I build
a driver for ARM platform, i.e. with a patched Makefile. In any case, you can just drop this
patch. I use these ICs with ARM architecture, and so I write an improved version of the driver
that will support all ICs from this series and do not depend on the architecture.
--
Alexander Shiyan <shc_work@mail.ru>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-08-01 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 8:00 [PATCH] serial: sc26xx: Fix compile breakage Alexander Shiyan
2012-08-01 12:56 ` Greg Kroah-Hartman
2012-08-01 14:55 ` Re[2]: " Alexander Shiyan
2012-08-01 15:04 ` Greg Kroah-Hartman
2012-08-01 17:44 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801214416.36e82420.shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).