From: Alexander Shiyan <shc_work@mail.ru>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] serial: New serial driver SCCNXP
Date: Wed, 29 Aug 2012 22:26:42 +0400 [thread overview]
Message-ID: <20120829222642.bae75223.shc_work@mail.ru> (raw)
In-Reply-To: <20120829144607.5cad63e2@pyramind.ukuu.org.uk>
On Wed, 29 Aug 2012 14:46:07 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
Thanks for review.
> > + baud = uart_get_baud_rate(port, termios, old, 50,
> > + (s->flags & SCCNXP_HAVE_MR0) ?
> > + 230400 : 38400);
> > + sccnxp_set_baud(port, baud);
> You should also write the *actal* baud rate you end up with back into
> termios unless B0 is requested (see 8250.c for an example). The tty core
> code will deal with minor variations and the detail for you (eg a user
> asking for B9600 and getting 9605 will be told they got their baud rate
> as asked)
And AFAIK uart_get_baud_rate cannot return 0 for us, so check for zero baud
is not needed before call tty_termios_encode_baud_rate. Right?
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2012-08-29 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 15:24 [PATCH 1/2] serial: New serial driver SCCNXP Alexander Shiyan
2012-08-25 15:24 ` [PATCH 2/2] serial: Add note about migration to " Alexander Shiyan
2012-08-29 13:46 ` [PATCH 1/2] serial: New serial " Alan Cox
2012-08-29 18:26 ` Alexander Shiyan [this message]
2012-08-29 20:15 ` Alan Cox
2012-09-05 20:24 ` Greg Kroah-Hartman
2012-09-24 16:50 ` Alexander Shiyan
2012-09-24 17:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120829222642.bae75223.shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).