From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Young Subject: Re: [PATCH 2/2] 8250: blacklist IR ports Date: Fri, 7 Sep 2012 12:37:48 +0100 Message-ID: <20120907113748.GA28165@pequod.mess.org> References: <20120907010135.6a4d0a20@pyramind.ukuu.org.uk> <20120907093020.GA26788@pequod.mess.org> <20120907112510.3c2eb62f@pyramind.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pequod.mess.org ([93.97.41.153]:38537 "EHLO pequod.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138Ab2IGLhv (ORCPT ); Fri, 7 Sep 2012 07:37:51 -0400 Content-Disposition: inline In-Reply-To: <20120907112510.3c2eb62f@pyramind.ukuu.org.uk> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Alan Cox Cc: Alan Cox , Greg Kroah-Hartman , linux-serial@vger.kernel.org, David =?iso-8859-1?Q?H=E4rdeman?= , Mauro Carvalho Chehab On Fri, Sep 07, 2012 at 11:25:10AM +0100, Alan Cox wrote: > > At least for the nsc-ircc driver, user space must manually remove the > > the uart driver and then load the nsc-ircc driver. This patch also > > The nsc can be driven in both SIR and FIR mode can it not. The serial > driver should drive it in SIR mode if so which means we need to be a spot > more careful. Oops. > > fixes that for nsc-ircc devices. It should work although I am unable to > > find the hardware to test it on yet, I used to have one of these. Testers > > would be appreciated. See: > > Until it can be tested can we keep the nsc-ircc case separate. At most we > might need two identifiers (PORT_8250_CIR PORT_8250_FIR etc) Ok. I'll send out new patches over the weekend, after testing. Thanks, Sean