From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 5/5] omap-serial: Request pins using pinctrl framework Date: Fri, 7 Sep 2012 11:03:36 -0700 Message-ID: <20120907180335.GF1303@atomide.com> References: <20120906185615.1172.23588.stgit@muffinssi.local> <20120906185832.1172.31013.stgit@muffinssi.local> <331ABD5ECB02734CA317220B2BBEABC13EA291F9@DBDE01.ent.ti.com> <20120907172809.GB1303@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:27930 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752530Ab2IGSDk (ORCPT ); Fri, 7 Sep 2012 14:03:40 -0400 Content-Disposition: inline In-Reply-To: <20120907172809.GB1303@atomide.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: "AnilKumar, Chimata" Cc: "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-omap@vger.kernel.org" , "linux-serial@vger.kernel.org" * Tony Lindgren [120907 10:29]: > * AnilKumar, Chimata [120906 20:27]: > > > @@ -1570,6 +1578,8 @@ static int serial_omap_remove(struct platform_device *dev) > > > pm_runtime_disable(&up->pdev->dev); > > > uart_remove_one_port(&serial_omap_reg, &up->port); > > > pm_qos_remove_request(&up->pm_qos_request); > > > + if (up->pins) > > > + pinctrl_put(up->pins); > > > > I think this can be removed if we use devm_pinctrl_get_select_default() > > above. > > Yeah will do, I was initially thinking that would cause issues remuxing > pins back to safe mode on unload, but we can still do that in > serial_omap_remove(). Sent now as a separate patch with subject "[PATCH] serial: omap: Request pins using pinctrl framework". Regards, Tony