From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Guillaume Jaunet <guillaume.jaunet@stericsson.com>,
Par-Gunnar Hjalmdahl <par-gunnar.hjalmdahl@stericsson.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Matthias Locher <matthias.locher@stericsson.com>,
"Rajanikanth H.V" <rajanikanth.hv@stericsson.com>,
Christophe Arnal <christophe.arnal@stericsson.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] serial: pl011: allow very high baudrates
Date: Thu, 20 Sep 2012 20:00:34 +0100 [thread overview]
Message-ID: <20120920190034.GB15609@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1348134368-25663-1-git-send-email-linus.walleij@stericsson.com>
On Thu, Sep 20, 2012 at 11:46:08AM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The ST Microelectronics variant of the PL011 is capable of supporting
> very high non-standard baud rates, even above 4 Mbps. However the
> uart_get_baud_rate() will not allow us to set these, so override that
> calculation on very high speeds.
You don't explain why it doesn't. It should in theory allow you to,
because there's no limits within that function other than those which
you pass in as the minimum and maximum.
If your userspace hasn't been updated to use the integer baud rate
setting mechanisms, then that could be where the problem lies.
Alternatively, if some Bxxxx setting is not being respected by
tty_termios_baud_rate(), that also would need fixing.
But the fix you propose in this patch just looks wrong.
next prev parent reply other threads:[~2012-09-20 19:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 9:46 [PATCH 3/3] serial: pl011: allow very high baudrates Linus Walleij
2012-09-20 19:00 ` Russell King - ARM Linux [this message]
2012-09-21 13:41 ` Linus Walleij
2012-09-21 14:37 ` Alan Cox
2012-09-21 14:58 ` Russell King - ARM Linux
2012-09-21 15:05 ` Alan Cox
2012-09-21 15:06 ` Russell King - ARM Linux
2012-09-21 15:36 ` Alan Cox
2012-09-21 15:14 ` Alan Cox
2012-09-21 15:25 ` Alan Cox
2012-09-21 17:52 ` Linus Walleij
2012-09-21 19:56 ` Alan Cox
2012-09-21 20:34 ` Russell King - ARM Linux
2012-09-21 20:55 ` Alan Cox
2012-09-25 18:48 ` Linus Walleij
2012-09-25 19:00 ` Alan Cox
2012-09-26 8:06 ` Linus Walleij
2012-09-26 10:04 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920190034.GB15609@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=anmar.oueja@linaro.org \
--cc=christophe.arnal@stericsson.com \
--cc=gregkh@linuxfoundation.org \
--cc=guillaume.jaunet@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.locher@stericsson.com \
--cc=par-gunnar.hjalmdahl@stericsson.com \
--cc=rajanikanth.hv@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).