From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 3/3] serial: pl011: allow very high baudrates Date: Fri, 21 Sep 2012 15:37:10 +0100 Message-ID: <20120921153710.220adb92@bob.linux.org.uk> References: <1348134368-25663-1-git-send-email-linus.walleij@stericsson.com> <20120920190034.GB15609@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([143.182.124.37]:45084 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755282Ab2IUOfu (ORCPT ); Fri, 21 Sep 2012 10:35:50 -0400 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Linus Walleij Cc: Russell King - ARM Linux , Greg Kroah-Hartman , Linus Walleij , linux-serial@vger.kernel.org, Guillaume Jaunet , Par-Gunnar Hjalmdahl , Anmar Oueja , Matthias Locher , "Rajanikanth H.V" , Christophe Arnal , linux-arm-kernel@lists.infradead.org > Device drivers should use c_[io]speed directly! > > Alan Cox wrote this, so Alan: should I just ditch the use of > uart_get_baud_rate() and program the divider directly from > c_[io]speed? Yes. The functions are designed to act as helpers for old devices. In fact we can actually probably abolish tty_termios_baud_rate at this point as I don't think there is much if anything left which blows up fed a non Bxxx table entry. I will have a look at that in fact see what it involves at this point. Alan