From: Alexander Shiyan <shc_work@mail.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/2] serial: New serial driver SCCNXP
Date: Mon, 24 Sep 2012 20:50:47 +0400 [thread overview]
Message-ID: <20120924205047.da73876b.shc_work@mail.ru> (raw)
In-Reply-To: <20120905202433.GA23267@kroah.com>
On Wed, 5 Sep 2012 13:24:33 -0700
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
...
> > +config SERIAL_SCCNXP
> > + bool "SCCNXP serial port support"
> > + depends on !SERIAL_SC26XX
> > + select SERIAL_CORE
> > + default n
> > + help
> > + This selects support for an advanced UART from NXP (Philips).
> > + Supported ICs are SCC2681, SCC2691, SCC2692, SC28L91, SC28L92,
> > + SC28L202, SCC68681 and SCC68692.
> > + Positioned as a replacement for the driver SC26XX.
>
> This driver can be built as a module, right? If so, please change this
> to a tristate variable, not a "bool". I don't feel like always building
> it into my kernels :)
> Care to send a follow-on patch fixing this up?
I'm not sure whether the driver works as a module, as in the case of the
module, we can not setup at least IO-address and IRQ parameters. Or, we are
need to create module_param variables.
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2012-09-24 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 15:24 [PATCH 1/2] serial: New serial driver SCCNXP Alexander Shiyan
2012-08-25 15:24 ` [PATCH 2/2] serial: Add note about migration to " Alexander Shiyan
2012-08-29 13:46 ` [PATCH 1/2] serial: New serial " Alan Cox
2012-08-29 18:26 ` Alexander Shiyan
2012-08-29 20:15 ` Alan Cox
2012-09-05 20:24 ` Greg Kroah-Hartman
2012-09-24 16:50 ` Alexander Shiyan [this message]
2012-09-24 17:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924205047.da73876b.shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).