From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Yuanhan Liu <yuanhan.liu@intel.com>,
kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [tty:tty-next 36/40] kernel/debug/kdb/kdb_main.c:2839:4: warning: passing argument 2 of 'kdb_register_repeat' from incompatible pointer type
Date: Wed, 26 Sep 2012 19:11:19 -0700 [thread overview]
Message-ID: <20120927021119.GA29097@lizard> (raw)
In-Reply-To: <20120927013930.GA27336@lizard>
On Wed, Sep 26, 2012 at 06:39:32PM -0700, Anton Vorontsov wrote:
> On Thu, Sep 27, 2012 at 09:29:16AM +0800, Fengguang Wu wrote:
> > FYI, there are new compile warnings show up in
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> > head: 0c57dfcc6c1d037243c2f8fbf62eab3633326ec0
> > commit: 729043e82cdd403a131127254528afea8031ebab [36/40] kdb: Turn KGDB_KDB=n stubs into static inlines
> > config: cris-allyesconfig
> >
> > All warnings (together with lots of *old* errors):
>
> As we switched from empty macros to proper type-checking functions, the
> new warnings most probably are all OK, but just to be sure...
>
> Which are the new warnings? Do you have old build logs to compare?
I guess these are the new ones:
> > kernel/debug/kdb/kdb_main.c:2839:4: warning: passing argument 2 of 'kdb_register_repeat' from incompatible pointer type [enabled by default]
> > kernel/debug/kdb/kdb_main.c:2696:5: note: expected 'kdb_func_t' but argument is of type 'struct kdbmsg_t *'
> > kernel/debug/kdb/kdb_main.c:2841:4: warning: passing argument 2 of 'kdb_register_repeat' from incompatible pointer type [enabled by default]
They're all OK. Before my patch, kgdb_register_repeat() was an empty
macro. But since we now do proper functions, the new warnings pop up.
Also, there's something interesting:
> > kernel/debug/kdb/kdb_main.c:2696:5: error: redefinition of 'kdb_register_repeat'
> > include/linux/kdb.h:156:19: note: previous definition of 'kdb_register_repeat' was here
This means that we're trying to build KDB, but kdb.h don't see
CONFIG_KGDB_KDB.
More over, 'make ARCH=cris allyesconfig' producing .config with KGDB=n
and KGDB_KDB=n. And criss doesn't select HAVE_ARCH_KGDB.
I suspect there are some toolchain issues, or arch/cris/ does something
weird with the build system.
Also, "arch/cris/arch-v32/kernel/kgdb.c" -- it seems like it is its own
implementation of KGDB. :-) But it's CONFIG_ETRAX_KGDB...
So, I don't even think KGDB/KDB should be fixed anyhow, since cris doesn't
select HAVE_ARCH_KGDB, thus 'depends on !CRIS' doesn't make sense.
Thanks,
Anton.
next prev parent reply other threads:[~2012-09-27 2:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 1:29 [tty:tty-next 36/40] kernel/debug/kdb/kdb_main.c:2839:4: warning: passing argument 2 of 'kdb_register_repeat' from incompatible pointer type Fengguang Wu
2012-09-27 1:32 ` Greg Kroah-Hartman
2012-09-27 1:36 ` Fengguang Wu
2012-09-27 2:15 ` Greg Kroah-Hartman
2012-09-27 1:39 ` Anton Vorontsov
2012-09-27 2:01 ` Fengguang Wu
2012-09-27 2:11 ` Anton Vorontsov [this message]
2012-09-27 2:36 ` Fengguang Wu
2012-09-27 2:52 ` Anton Vorontsov
2012-09-27 2:59 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927021119.GA29097@lizard \
--to=anton.vorontsov@linaro.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox