linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] serial: sccnxp: Allows the driver to be compiled as a module
@ 2012-09-30  9:19 Alexander Shiyan
  2012-10-05 16:37 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2012-09-30  9:19 UTC (permalink / raw)
  To: linux-serial; +Cc: Alan Cox, Greg Kroah-Hartman, Alexander Shiyan


Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/tty/serial/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 750671d..b7aaa95 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1105,7 +1105,7 @@ config SERIAL_SC26XX_CONSOLE
 	  Support for Console on SC2681/SC2692 serial ports.
 
 config SERIAL_SCCNXP
-	bool "SCCNXP serial port support"
+	tristate "SCCNXP serial port support"
 	depends on !SERIAL_SC26XX
 	select SERIAL_CORE
 	default n
@@ -1117,7 +1117,7 @@ config SERIAL_SCCNXP
 
 config SERIAL_SCCNXP_CONSOLE
 	bool "Console on SCCNXP serial port"
-	depends on SERIAL_SCCNXP
+	depends on SERIAL_SCCNXP=y
 	select SERIAL_CORE_CONSOLE
 	help
 	  Support for console on SCCNXP serial ports.
-- 
1.7.8.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: sccnxp: Allows the driver to be compiled as a module
  2012-09-30  9:19 [PATCH] serial: sccnxp: Allows the driver to be compiled as a module Alexander Shiyan
@ 2012-10-05 16:37 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2012-10-05 16:37 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: linux-serial, Alan Cox

On Sun, Sep 30, 2012 at 01:19:19PM +0400, Alexander Shiyan wrote:
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Thanks for this fix, but as it breaks the build when you do this, it's
kind of sad that you haven't tested it out :(

I'll go fix up that build breakage when the driver is being built by a
module and push the fixes to Linus.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-05 16:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-30  9:19 [PATCH] serial: sccnxp: Allows the driver to be compiled as a module Alexander Shiyan
2012-10-05 16:37 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).