From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Ivo Sieben <meltedpianoman@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [REPOST] RFC: sched: Prevent wakeup to enter critical section needlessly
Date: Tue, 9 Oct 2012 17:17:29 +0200 [thread overview]
Message-ID: <20121009151729.GA3521@redhat.com> (raw)
In-Reply-To: <1349792104.7880.41.camel@twins>
On 10/09, Peter Zijlstra wrote:
>
> One thing you might need to consider is the memory ordering, will the
> list_empty -- either careful or not -- observe the right list pointer,
> or could it -- when racing with wait_event()/prepare_to_wait() --
> observe a stale value. Or.. is that all already covered in on the use
> site.
I agree.
Without spin_lock(q->lock) (or some other barriers) wait_event-like
code can miss an event.
wait_event:
prepare_to_wait(wq) // takes wq->lock
if (!CONDITION)
schedule();
Now,
CONDITION = 1;
wake_up(wq);
at least need the full mb() before lits_empty().
Oleg.
next prev parent reply other threads:[~2012-10-09 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 13:06 [PATCH] RFC: sched: Prevent wakeup to enter critical section needlessly Ivo Sieben
2012-10-09 11:30 ` [REPOST] " Ivo Sieben
2012-10-09 13:37 ` Andi Kleen
2012-10-09 14:15 ` Peter Zijlstra
2012-10-09 15:17 ` Oleg Nesterov [this message]
2012-10-10 14:02 ` Andi Kleen
2012-10-18 8:30 ` [PATCH-v2] " Ivo Sieben
2012-10-25 10:12 ` [REPOST-v2] " Ivo Sieben
2012-11-19 7:30 ` Ivo Sieben
2012-11-19 10:20 ` Preeti U Murthy
2012-11-19 15:10 ` Oleg Nesterov
2012-11-19 15:34 ` Ivo Sieben
2012-11-19 15:49 ` Oleg Nesterov
2012-11-21 13:03 ` Ivo Sieben
2012-11-21 13:47 ` Alan Cox
2012-11-21 13:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009151729.GA3521@redhat.com \
--to=oleg@redhat.com \
--cc=alan@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).