From: Alexander Shiyan <shc_work@mail.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] serial: clps711x: reworked driver version
Date: Thu, 11 Oct 2012 22:57:03 +0400 [thread overview]
Message-ID: <20121011225703.3f930bf1.shc_work@mail.ru> (raw)
In-Reply-To: <20121011183406.GC32470@kroah.com>
On Fri, 12 Oct 2012 03:34:06 +0900
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Oct 11, 2012 at 07:51:29PM +0400, Alexander Shiyan wrote:
> > This patch presents reworked version of CLPS711X serial driver.
> > The changes from the old version:
> > - Driver converted to platform_device.
> > - Using CPU clock subsystem for getting base UART speed, since CPU can run
> > on different speeds.
> > - Remove console_initcall and make console dynamically. Earler messages in
> > this case can be retrieved by using "earlyprintk" kernel option.
> > - Using resource-managed functions (devm_xx).
> > - Make all variables dynamically (reduce BSS).
> > - Cleanup code & comments.
>
> That's a lot of different things, all at once, making it very hard to
> review.
> Can you please break this up into the individual patches of what you are
> doing above, one patch per thing, as is needed for Linux kernel patches?
> That way it is much easier to accept and review.
It's too hard to do, since each modification depends on the other...
Maybe make a patch through renaming, for example clps711x_uart? Or you
still insist to split it into separate patches?
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2012-10-11 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 15:51 [PATCH] serial: clps711x: reworked driver version Alexander Shiyan
2012-10-11 18:34 ` Greg Kroah-Hartman
2012-10-11 18:57 ` Alexander Shiyan [this message]
2012-10-11 19:20 ` Greg Kroah-Hartman
2012-10-14 7:05 ` Alexander Shiyan
2012-10-15 10:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011225703.3f930bf1.shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).