* [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
@ 2012-10-23 2:30 Fengguang Wu
2012-10-23 9:53 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Fengguang Wu @ 2012-10-23 2:30 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Yuanhan Liu, Greg Kroah-Hartman, linux-serial
Hi Jiri,
FYI, kernel build failed on
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
commit: ba2e68ac6157004ee4922fb39ebd9459bbae883e [17/23] TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff
config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
All error/warnings:
drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
vim +229 drivers/staging/dgrp/dgrp_net_ops.c
0b52b749 Bill Pemberton 2012-09-20 228 /* take into consideration length of ldisc */
0b52b749 Bill Pemberton 2012-09-20 @229 len = min(len, (N_TTY_BUF_SIZE - 1) - tty->read_cnt);
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
2012-10-23 2:30 [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt' Fengguang Wu
@ 2012-10-23 9:53 ` Alan Cox
2012-10-23 10:00 ` Fengguang Wu
2012-10-27 12:20 ` Jiri Slaby
0 siblings, 2 replies; 5+ messages in thread
From: Alan Cox @ 2012-10-23 9:53 UTC (permalink / raw)
To: Fengguang Wu; +Cc: Jiri Slaby, Yuanhan Liu, Greg Kroah-Hartman, linux-serial
On Tue, 23 Oct 2012 10:30:54 +0800
Fengguang Wu <fengguang.wu@intel.com> wrote:
> Hi Jiri,
>
> FYI, kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
> commit: ba2e68ac6157004ee4922fb39ebd9459bbae883e [17/23] TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff
> config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
>
> All error/warnings:
>
> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
>
> vim +229 drivers/staging/dgrp/dgrp_net_ops.c
>
> 0b52b749 Bill Pemberton 2012-09-20 228 /* take into consideration length of ldisc */
> 0b52b749 Bill Pemberton 2012-09-20 @229 len = min(len, (N_TTY_BUF_SIZE - 1) - tty->read_cnt);
This is broken and unsafe. It's always been broken and unsafe. Probably
the report wants directing to whoever signed up to fix it all in staging.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
2012-10-23 9:53 ` Alan Cox
@ 2012-10-23 10:00 ` Fengguang Wu
2012-10-27 12:20 ` Jiri Slaby
1 sibling, 0 replies; 5+ messages in thread
From: Fengguang Wu @ 2012-10-23 10:00 UTC (permalink / raw)
To: Alan Cox
Cc: Bill Pemberton, Jiri Slaby, Yuanhan Liu, Greg Kroah-Hartman,
linux-serial
On Tue, Oct 23, 2012 at 10:53:30AM +0100, Alan Cox wrote:
> On Tue, 23 Oct 2012 10:30:54 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
>
> > Hi Jiri,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> > head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
> > commit: ba2e68ac6157004ee4922fb39ebd9459bbae883e [17/23] TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff
> > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
> >
> > All error/warnings:
> >
> > drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> > drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> > drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> > drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> > drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> > drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
> >
> > vim +229 drivers/staging/dgrp/dgrp_net_ops.c
> >
> > 0b52b749 Bill Pemberton 2012-09-20 228 /* take into consideration length of ldisc */
> > 0b52b749 Bill Pemberton 2012-09-20 @229 len = min(len, (N_TTY_BUF_SIZE - 1) - tty->read_cnt);
>
> This is broken and unsafe. It's always been broken and unsafe. Probably
> the report wants directing to whoever signed up to fix it all in staging.
Add CC to Bill. Alan, thanks for the suggestion!
As for the build system, it perhaps can hardly be more smart than
notifying the contacts for the commit that *directly* triggered the
build errors (bisected first bad commit is not necessary the root
cause). It relies on the CCed developers to figure out the real
problem and if necessary, add more CC list.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
2012-10-23 9:53 ` Alan Cox
2012-10-23 10:00 ` Fengguang Wu
@ 2012-10-27 12:20 ` Jiri Slaby
2012-10-27 15:01 ` Greg Kroah-Hartman
1 sibling, 1 reply; 5+ messages in thread
From: Jiri Slaby @ 2012-10-27 12:20 UTC (permalink / raw)
To: Alan Cox
Cc: Fengguang Wu, Yuanhan Liu, Greg Kroah-Hartman, linux-serial,
Bill Pemberton
On 10/23/2012 11:53 AM, Alan Cox wrote:
> On Tue, 23 Oct 2012 10:30:54 +0800
> Fengguang Wu <fengguang.wu@intel.com> wrote:
>
>> Hi Jiri,
>>
>> FYI, kernel build failed on
>>
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
>> head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
>> commit: ba2e68ac6157004ee4922fb39ebd9459bbae883e [17/23] TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff
>> config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
>>
>> All error/warnings:
>>
>> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
>> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
>> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
>> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
>> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
>> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
>>
>> vim +229 drivers/staging/dgrp/dgrp_net_ops.c
>>
>> 0b52b749 Bill Pemberton 2012-09-20 228 /* take into consideration length of ldisc */
>> 0b52b749 Bill Pemberton 2012-09-20 @229 len = min(len, (N_TTY_BUF_SIZE - 1) - tty->read_cnt);
>
> This is broken and unsafe. It's always been broken and unsafe. Probably
> the report wants directing to whoever signed up to fix it all in staging.
And that function looks strange alltogether. It's like it's trying to
optimize in case of raw TTY by sending the data directly to ldisc. In a
completely racy way. I think that it should remain marked as BROKEN
until this is converted to tty_prepare_flip_string.
Or is there any use-case this optimization makes a difference?
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
2012-10-27 12:20 ` Jiri Slaby
@ 2012-10-27 15:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2012-10-27 15:01 UTC (permalink / raw)
To: Jiri Slaby
Cc: Alan Cox, Fengguang Wu, Yuanhan Liu, linux-serial, Bill Pemberton
On Sat, Oct 27, 2012 at 02:20:28PM +0200, Jiri Slaby wrote:
> On 10/23/2012 11:53 AM, Alan Cox wrote:
> > On Tue, 23 Oct 2012 10:30:54 +0800
> > Fengguang Wu <fengguang.wu@intel.com> wrote:
> >
> >> Hi Jiri,
> >>
> >> FYI, kernel build failed on
> >>
> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> >> head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
> >> commit: ba2e68ac6157004ee4922fb39ebd9459bbae883e [17/23] TTY: move ldisc data from tty_struct: read_* and echo_* and canon_* stuff
> >> config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
> >>
> >> All error/warnings:
> >>
> >> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> >> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> >> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> >> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> >> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> >> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
> >>
> >> vim +229 drivers/staging/dgrp/dgrp_net_ops.c
> >>
> >> 0b52b749 Bill Pemberton 2012-09-20 228 /* take into consideration length of ldisc */
> >> 0b52b749 Bill Pemberton 2012-09-20 @229 len = min(len, (N_TTY_BUF_SIZE - 1) - tty->read_cnt);
> >
> > This is broken and unsafe. It's always been broken and unsafe. Probably
> > the report wants directing to whoever signed up to fix it all in staging.
>
> And that function looks strange alltogether. It's like it's trying to
> optimize in case of raw TTY by sending the data directly to ldisc. In a
> completely racy way. I think that it should remain marked as BROKEN
> until this is converted to tty_prepare_flip_string.
That code has been ripped out of the driver now, and it builds fine in
my tree, so the BROKEN marking linux-next can be removed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-27 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 2:30 [tty:tty-next 17/23] drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt' Fengguang Wu
2012-10-23 9:53 ` Alan Cox
2012-10-23 10:00 ` Fengguang Wu
2012-10-27 12:20 ` Jiri Slaby
2012-10-27 15:01 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).