From: Alan Cox <alan@linux.intel.com>
To: chao bi <chao.bi@intel.com>
Cc: linux-serial@vger.kernel.org, richardx.r.gorby@intel.com,
chuansheng.liu@intel.com, jun.d.chen@intel.com
Subject: Re: [PATCH] serial:ifx6x60:Prevent data transfer when IFX6x60 port is shutdown
Date: Thu, 1 Nov 2012 11:48:20 +0000 [thread overview]
Message-ID: <20121101114820.52c280be@bob.linux.org.uk> (raw)
In-Reply-To: <1351673647.4445.25.camel@bichao>
On Wed, 31 Oct 2012 16:54:07 +0800
chao bi <chao.bi@intel.com> wrote:
>
> This patch is to implement following 2 places to avoid potential
> error when IFX6x60 port shutdown: 1) Clear Flag
> IFX_SPI_STATE_IO_AVAILABLE to disable data transfer when Modem port
> is shutdown; 2) Clear Flag IFX_SPI_STATE_IO_IN_PROGRESS and
> IFX_SPI_STATE_IO_READY when reopen port. This is because last port
> shutdown may happen when SPI/DMA transfer is in progress, if the last
> data transfer is not completed(for example due to modem reset), the
> Flag IFX_SPI_STATE_IO_IN_PROGRESS will be set forever, so when IFX
> port is activated again, IFX_SPI_STATE_IO_IN_PROGRESS will prevent
> transferring data forever. And if don't clear IFX_SPI_STATE_IO_READY,
> it may cause one more SPI frame transferring in spit there is not
> data need to be transfer.
>
> cc: liu chuansheng <chuansheng.liu@intel.com>
> cc: Chen Jun <jun.d.chen@intel.com>
> Signed-off-by: channing <chao.bi@intel.com>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-11-01 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 8:54 [PATCH] serial:ifx6x60:Prevent data transfer when IFX6x60 port is shutdown chao bi
2012-11-01 11:48 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101114820.52c280be@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=chao.bi@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=jun.d.chen@intel.com \
--cc=linux-serial@vger.kernel.org \
--cc=richardx.r.gorby@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).