Re: Comments requested: driver for Quatech PCI serial cards

Greg KH
2012-11-28T17:30:12Z

On Thu, Nov 29, 2012 at 12:11:40AM +1030, Jonathan Woithe wrote:
> On Wed, Nov 28, 2012 at 01:24:19PM +0000, Alan Cox wrote:
> > > With regard to the ioctl, should this be an implementation of the ioctl
> > > provided by the old out-of-tree driver, or is there an established
> > > standard/example which I should write against instead?
> >
> > We have a standard (if possibly needing a few bits adding) ioctl for
> > basic RS422/485 features. That's TIOCG/SRS485 (which for all the naming
> > is also kind of 422 and other related bits as well)
>
> Ok, thanks for the pointer. I'll take a look at this in due course.
>
> > Can we get a Signed-off-by: for the first patch so we can try and get it
> > into 3.8 ?
>
> Sure. See below. The rest of the previous commit message was fine so I
> haven't replicated it here.

Please do, otherwise I have to hand-edit the patch to add it back, and
odds are, I will get it wrong...

thanks,

greg k-h