From: Grant Likely <grant.likely@secretlab.ca>
To: Wei Yongjun <weiyj.lk@gmail.com>,
alan@linux.intel.com, gregkh@linuxfoundation.org,
rob.herring@calxeda.com, seth.heasley@intel.com,
stable@kernel.org
Cc: yongjun_wei@trendmicro.com.cn, linux-serial@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup()
Date: Thu, 15 Nov 2012 12:08:11 +0000 [thread overview]
Message-ID: <20121115120811.B9EB63E0B12@localhost> (raw)
In-Reply-To: <CAPgLHd--dWeXNH_QVU34afv5Q1ju2MZJcwLKwyRr89+RvOTOBw@mail.gmail.com>
On Thu, 1 Nov 2012 13:27:34 +0800, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks correct to me.
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Alan, which tree should this go through?
Wei, did you run into this causing a bug? Do you think it should go back
into linux-stable? It looks like it should to me.
g.
> ---
> drivers/tty/serial/of_serial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 533ccfe..b9fdccb 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -66,10 +66,10 @@ static int __devinit of_platform_serial_setup(struct platform_device *ofdev,
>
> /* Get clk rate through clk driver if present */
> info->clk = clk_get(&ofdev->dev, NULL);
> - if (info->clk == NULL) {
> + if (IS_ERR(info->clk)) {
> dev_warn(&ofdev->dev,
> "clk or clock-frequency not defined\n");
> - return -ENODEV;
> + return PTR_ERR(info->clk);
> }
>
> clk_prepare_enable(info->clk);
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-11-15 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 5:27 [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup() Wei Yongjun
2012-11-01 14:00 ` Murali Karicheri
2012-11-01 14:48 ` Alan Cox
2012-11-15 12:08 ` Grant Likely [this message]
2012-11-16 1:22 ` Greg KH
2012-11-16 2:21 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115120811.B9EB63E0B12@localhost \
--to=grant.likely@secretlab.ca \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=seth.heasley@intel.com \
--cc=stable@kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).