From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Jun Chen <jun.d.chen@intel.com>, linux-serial@vger.kernel.org
Subject: Re: [tty:tty-next 76/76] drivers/tty/serial/ifx6x60.c:516:2: warning: ISO C90 forbids mixed declarations and code
Date: Thu, 15 Nov 2012 18:06:05 -0800 [thread overview]
Message-ID: <20121116020605.GA30669@kroah.com> (raw)
In-Reply-To: <50a59244.WYf95+M2VB2UsDXN%fengguang.wu@intel.com>
On Fri, Nov 16, 2012 at 09:09:24AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> head: e8823f1ca8d5a0c5d69a8862682ee8bde26990ca
> commit: e8823f1ca8d5a0c5d69a8862682ee8bde26990ca [76/76] serial: ifx6x60: ifx_spi_write don't need to do mrdy_assert when fifo is not empty
> config: i386-randconfig-b691 (attached as .config)
>
> All warnings:
>
> drivers/tty/serial/ifx6x60.c: In function 'ifx_spi_write':
> drivers/tty/serial/ifx6x60.c:516:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
Ah, missed that one. Jun, care to send a fix for this?
> drivers/tty/serial/ifx6x60.c: In function 'ifx_spi_complete':
> drivers/tty/serial/ifx6x60.c:726:8: warning: 'more' may be used uninitialized in this function [-Wmaybe-uninitialized]
And verify that this isn't a real problem please.
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-16 2:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 1:09 [tty:tty-next 76/76] drivers/tty/serial/ifx6x60.c:516:2: warning: ISO C90 forbids mixed declarations and code kbuild test robot
2012-11-16 2:06 ` Greg Kroah-Hartman [this message]
2012-11-16 2:16 ` Chen, Jun D
2012-11-16 3:13 ` Chen, Jun D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116020605.GA30669@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fengguang.wu@intel.com \
--cc=jun.d.chen@intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox