From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Joachim Eastwood <manabian@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [RFC 3/3] ARM/AVR32: get rid of serial_at91.h
Date: Fri, 16 Nov 2012 23:08:36 +0000 [thread overview]
Message-ID: <20121116230835.GR3290@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAGhQ9VzYc8qqvZxU=AB+NHa4nGKJFxPYR7grc8Ssn-kP1bfq3w@mail.gmail.com>
On Fri, Nov 16, 2012 at 11:08:47PM +0100, Joachim Eastwood wrote:
> When the atmel_open_hook/atmel_open_close assignment is dropped, these
> global variables will be useless so we should remove them as well.
> There are also some other code that uses the variables that can be
> dropped. Should shave another 22 lines of code off atmel_serial.c
>
> I can send out a patch on top of yours if you prefer that.
Yes please.
Thanks.
prev parent reply other threads:[~2012-11-16 23:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 9:35 [RFC 0/3] Move some ARM header files to more appropriate locations Russell King - ARM Linux
2012-09-21 9:36 ` [RFC 1/3] ARM: move serial_sa1100.h header file to linux/platform_data Russell King
2012-09-21 23:05 ` Greg Kroah-Hartman
2012-09-21 9:36 ` [RFC 2/3] ARM: move udc_pxa2xx.h " Russell King
[not found] ` <E1TEzet-00077v-VD-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2012-09-21 9:39 ` Felipe Balbi
2012-09-21 9:40 ` Eric Miao
2012-09-21 9:48 ` Russell King - ARM Linux
2012-09-22 11:41 ` Krzysztof Halasa
2012-09-21 23:05 ` Greg Kroah-Hartman
2012-09-21 9:36 ` [RFC 3/3] ARM/AVR32: get rid of serial_at91.h Russell King
[not found] ` <E1TEzfE-000780-1t-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2012-09-21 23:05 ` Greg Kroah-Hartman
2012-11-16 9:53 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20121116095352.GF4398-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-11-16 10:12 ` Nicolas Ferre
[not found] ` <50A6119E.8010303-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-16 11:38 ` Russell King - ARM Linux
2012-11-16 20:46 ` Andrew Victor
2012-11-16 22:08 ` Joachim Eastwood
2012-11-16 23:08 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116230835.GR3290@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).