public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: linux-serial@vger.kernel.org
Subject: Re: Comments requested: driver for Quatech PCI serial cards
Date: Wed, 28 Nov 2012 13:24:19 +0000	[thread overview]
Message-ID: <20121128132419.1094d2d3@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20121128022917.GD28558@marvin.atrad.com.au>

> So far as getting something working for our case, the patch below is all
> that is required.  I do know the QMCR and QOPR bit map details for at least
> the DSC-200/300 card as it's more or less described in the manual.  I will
> try to prepare a second patch which at least creates the necessary defines
> for these in the next few days.

Thanks.

> With regard to the ioctl, should this be an implementation of the ioctl
> provided by the old out-of-tree driver, or is there an established
> standard/example which I should write against instead?

We have a standard (if possibly needing a few bits adding) ioctl for
basic RS422/485 features. That's TIOCG/SRS485 (which for all the naming
is also kind of 422 and other related bits as well)

Can we get a Signed-off-by: for the first patch so we can try and get it
into 3.8 ?

Alan

  reply	other threads:[~2012-11-28 13:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  6:07 Comments requested: driver for Quatech PCI serial cards Jonathan Woithe
2012-11-14 12:12 ` Alan Cox
2012-11-14 23:10   ` Jonathan Woithe
2012-11-14 23:57     ` Alan Cox
2012-11-15  0:11       ` Jonathan Woithe
2012-11-15 15:53         ` Alan Cox
2012-11-15 22:23           ` Jonathan Woithe
2012-11-28  2:29           ` Jonathan Woithe
2012-11-28 13:24             ` Alan Cox [this message]
2012-11-28 13:41               ` Jonathan Woithe
2012-11-28 17:30                 ` Greg KH
2012-11-28 22:33                   ` Jonathan Woithe
2012-12-10  0:13                     ` Did quatech changes make 3.8? (was: Re: Comments requested: driver for Quatech PCI serial cards) Jonathan Woithe
2012-12-10  2:19                       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121128132419.1094d2d3@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jwoithe@just42.net \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox