From: Greg KH <gregkh@linuxfoundation.org>
To: Alexey Pelykh <alexey.pelykh@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-serial@vger.kernel.org
Subject: Re: Fwd: [PULL REQUEST] Tweak to support 1Mbaud and similar baudrates that require Mode16 instead of Mode13
Date: Wed, 28 Nov 2012 09:25:05 -0800 [thread overview]
Message-ID: <20121128172505.GB32286@kroah.com> (raw)
In-Reply-To: <CAOmKuSr+PYcs37DdiOj+h8wq0hjrdtHN4pCUvj-y97fr6-0DCA@mail.gmail.com>
On Wed, Nov 28, 2012 at 11:05:08AM +0200, Alexey Pelykh wrote:
> Original table in OMAP TRM named "UART Mode Baud Rates, Divisor
> Values, and Error Rates" determines modes not for all common baud
> rates. E.g. for 1000000 baud rate mode should be 16x, but according to
> that table it's determined as 13x. According to current implementation
> of mode
> divisor selection, after requesting 1000000 baudrate from driver,
> later one will configure chip to use MODE13 divisor. Assuming 48Mhz as
> common UART clock speed, MODE13 divisor will effectively give 1230769
> baudrate, what is quite far from desired 1000000 baudrate. While with
> MODE16 divisor, chip will produce exact 1000000 baudrate.
>
> In old driver that served UART devices (8250.c and serial_core.c) this
> divisor could have been configured by user-space program, but in
> omap_serial.c driver implementation this ability was not implemented
> (afaik, by design) thus disallowing proper usage of MODE16-compatible
> baudrates.
>
> Changes: I've fixed styling errors using ./scripts/checkpatch.pl
>
> Signed-off-by: Alexey Pelykh <alexey.pelykh@gmail.com>
>
> The following changes since commit 77b67063bb6bce6d475e910d3b886a606d0d91f7:
Again, I will not take a pull request, why do you keep on sending this?
Please just send your patch through mail, in a format that I can apply
it in (as described in Documentation/SubmittingPatches).
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-28 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOmKuSpRJhBibSDxTFCH157-XokhaFhvQ-gYxKZe+PfzokaBoA@mail.gmail.com>
2012-11-27 21:35 ` Fwd: [PULL REQUEST] Tweak to support 1Mbaud and similar baudrates that require Mode16 instead of Mode13 Alexey Pelykh
2012-11-27 21:46 ` Alan Cox
2012-11-27 21:56 ` Fwd: " Alexey Pelykh
2012-11-27 23:00 ` Alan Cox
2012-11-28 0:42 ` Fwd: " Greg KH
2012-11-28 9:05 ` Alexey Pelykh
2012-11-28 17:25 ` Greg KH [this message]
[not found] ` <CAOmKuSq52wWgetb53S1HiMNghT_A3UukPaUO0E9dXtWor+GVvw@mail.gmail.com>
2012-11-28 17:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128172505.GB32286@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alexey.pelykh@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox