From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-serial@vger.kernel.org
Subject: Re: Comments requested: driver for Quatech PCI serial cards
Date: Wed, 28 Nov 2012 09:30:10 -0800 [thread overview]
Message-ID: <20121128173010.GC32286@kroah.com> (raw)
In-Reply-To: <20121128134140.GA29452@marvin.atrad.com.au>
On Thu, Nov 29, 2012 at 12:11:40AM +1030, Jonathan Woithe wrote:
> On Wed, Nov 28, 2012 at 01:24:19PM +0000, Alan Cox wrote:
> > > With regard to the ioctl, should this be an implementation of the ioctl
> > > provided by the old out-of-tree driver, or is there an established
> > > standard/example which I should write against instead?
> >
> > We have a standard (if possibly needing a few bits adding) ioctl for
> > basic RS422/485 features. That's TIOCG/SRS485 (which for all the naming
> > is also kind of 422 and other related bits as well)
>
> Ok, thanks for the pointer. I'll take a look at this in due course.
>
> > Can we get a Signed-off-by: for the first patch so we can try and get it
> > into 3.8 ?
>
> Sure. See below. The rest of the previous commit message was fine so I
> haven't replicated it here.
Please do, otherwise I have to hand-edit the patch to add it back, and
odds are, I will get it wrong...
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-28 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 6:07 Comments requested: driver for Quatech PCI serial cards Jonathan Woithe
2012-11-14 12:12 ` Alan Cox
2012-11-14 23:10 ` Jonathan Woithe
2012-11-14 23:57 ` Alan Cox
2012-11-15 0:11 ` Jonathan Woithe
2012-11-15 15:53 ` Alan Cox
2012-11-15 22:23 ` Jonathan Woithe
2012-11-28 2:29 ` Jonathan Woithe
2012-11-28 13:24 ` Alan Cox
2012-11-28 13:41 ` Jonathan Woithe
2012-11-28 17:30 ` Greg KH [this message]
2012-11-28 22:33 ` Jonathan Woithe
2012-12-10 0:13 ` Did quatech changes make 3.8? (was: Re: Comments requested: driver for Quatech PCI serial cards) Jonathan Woithe
2012-12-10 2:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128173010.GC32286@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jwoithe@just42.net \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox