From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: alan@linux.intel.com, shawn.guo@linaro.org,
linux-serial@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] serial: mxs-auart: Index is unsigned
Date: Tue, 8 Jan 2013 07:58:04 +0100 [thread overview]
Message-ID: <201301080758.05051.marex@denx.de> (raw)
In-Reply-To: <1357607466-20358-1-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>>
>
> Fix the following warning when building with W=1 option:
>
> drivers/tty/serial/mxs-auart.c: In function 'mxs_auart_tx_chars':
> drivers/tty/serial/mxs-auart.c:272:10: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/tty/serial/mxs-auart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c
> b/drivers/tty/serial/mxs-auart.c index 6db23b0..537e0af 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -253,7 +253,7 @@ static void mxs_auart_tx_chars(struct mxs_auart_port
> *s) struct circ_buf *xmit = &s->port.state->xmit;
>
> if (auart_dma_enabled(s)) {
> - int i = 0;
> + u32 i = 0;
> int size;
> void *buffer = s->tx_dma_buf;
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-01-08 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 1:11 [PATCH] serial: mxs-auart: Index is unsigned Fabio Estevam
2013-01-08 6:58 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301080758.05051.marex@denx.de \
--to=marex@denx.de \
--cc=alan@linux.intel.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).