* [PATCH] serial: mxs-auart: Index is unsigned
@ 2013-01-08 1:11 Fabio Estevam
2013-01-08 6:58 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-01-08 1:11 UTC (permalink / raw)
To: alan; +Cc: shawn.guo, linux-serial, marex, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>>
Fix the following warning when building with W=1 option:
drivers/tty/serial/mxs-auart.c: In function 'mxs_auart_tx_chars':
drivers/tty/serial/mxs-auart.c:272:10: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/tty/serial/mxs-auart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 6db23b0..537e0af 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -253,7 +253,7 @@ static void mxs_auart_tx_chars(struct mxs_auart_port *s)
struct circ_buf *xmit = &s->port.state->xmit;
if (auart_dma_enabled(s)) {
- int i = 0;
+ u32 i = 0;
int size;
void *buffer = s->tx_dma_buf;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: mxs-auart: Index is unsigned
2013-01-08 1:11 [PATCH] serial: mxs-auart: Index is unsigned Fabio Estevam
@ 2013-01-08 6:58 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2013-01-08 6:58 UTC (permalink / raw)
To: Fabio Estevam; +Cc: alan, shawn.guo, linux-serial, Fabio Estevam
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>>
>
> Fix the following warning when building with W=1 option:
>
> drivers/tty/serial/mxs-auart.c: In function 'mxs_auart_tx_chars':
> drivers/tty/serial/mxs-auart.c:272:10: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/tty/serial/mxs-auart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c
> b/drivers/tty/serial/mxs-auart.c index 6db23b0..537e0af 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -253,7 +253,7 @@ static void mxs_auart_tx_chars(struct mxs_auart_port
> *s) struct circ_buf *xmit = &s->port.state->xmit;
>
> if (auart_dma_enabled(s)) {
> - int i = 0;
> + u32 i = 0;
> int size;
> void *buffer = s->tx_dma_buf;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-08 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 1:11 [PATCH] serial: mxs-auart: Index is unsigned Fabio Estevam
2013-01-08 6:58 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).