From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Chanho Min <chanho.min@lge.com>
Cc: 'Alan Cox' <alan@linux.intel.com>,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
'Linus Walleij' <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] ARM: PL011: Add support for Rx DMA buffer polling
Date: Fri, 11 Jan 2013 16:18:28 +0000 [thread overview]
Message-ID: <20130111161828.GD23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <006c01cdefc2$c7e1cb90$57a562b0$@min@lge.com>
On Fri, Jan 11, 2013 at 03:13:31PM +0900, Chanho Min wrote:
> In DMA support, Received data is not triggered until the DMA buffer is filled.
> In order to actually use Rx DMA, We would like to suggest the use of the timer
> for polling DMA buffer. It makes possible character-level trigger.
> In our test, no data loss occurred at high-baudrate as compared with interrupt
> driven (We tested with 3Mbps). We know it will be because of the increased Rx
> buffer rather than DMA effect. but,It is very useful for high speed uart device.
> We changes:
>
> - CONFIG_SERIAL_AMBA_PL011_DMAPOLL is added to select this feature.
>
> - add timer and last_residue for polling. Every polling, timer handler checks
> the residue in the dma buffer and transfer data to the tty. Also, last_residue
> is updated for the next polling.
>
> - We use consistent DMA mappings instead of streaming DMA mappings to avoid from
> the frequent cache operation.
>
> - pl011_dma_rx_chars is modified. the pending size is recalculated because data
> can be taken by polling.
>
> - add module parameter for adjusting polling interval.
Here's the question: what is the effect of having to poll every tick on
the overall system?
What I'm getting at is: what is the cost of that polling with DMA enabled
over not having DMA on the receive side at all? What is the trade-off
vs baud rate? Should we scale the polling interval according to baud
rate?
next parent reply other threads:[~2013-01-11 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <006c01cdefc2$c7e1cb90$57a562b0$@min@lge.com>
2013-01-11 16:18 ` Russell King - ARM Linux [this message]
[not found] <50efad8d.84fc440a.589e.ffff9546SMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-11 18:34 ` [PATCH] ARM: PL011: Add support for Rx DMA buffer polling Linus Walleij
[not found] ` <50f107aa.894e420a.596a.ffffe3f6SMTPIN_ADDED_BROKEN@mx.google.com>
2013-01-14 0:04 ` Linus Walleij
2013-01-14 0:26 ` Russell King - ARM Linux
2013-01-14 6:46 ` Linus Walleij
2013-01-14 7:27 ` Chanho Min
2013-01-14 7:56 ` Linus Walleij
2013-01-14 8:41 ` Chanho Min
2013-03-27 9:38 Chanho Min
2013-03-29 16:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111161828.GD23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alan@linux.intel.com \
--cc=chanho.min@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).