From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Nguyen <afelion@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] RS485 serial communication on ColdFire
Date: Mon, 14 Jan 2013 18:30:29 -0800 [thread overview]
Message-ID: <20130115023029.GA6049@kroah.com> (raw)
In-Reply-To: <CAODWn4ocfK7oxSNi-VNemuTGM1izZeCOPXD9rzN5aOMksZcrtA@mail.gmail.com>
On Tue, Jan 15, 2013 at 12:09:28PM +1000, Kevin Nguyen wrote:
> On Tue, Jan 15, 2013 at 12:28 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > Can you also remove the debugging printk() messages you added? Or,
> > convert them to dev_dbg() calls instead? If you run your patch through
> > the scripts/checkpatch.pl tool, it should tell you things like this.
>
> Those issues are fixed in the patch attached.
Nice, I'll queue this up later this week unless someone objects.
thanks,
greg k-h
prev parent reply other threads:[~2013-01-15 2:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 23:21 [PATCH] RS485 serial communication on ColdFire Kevin Nguyen
2013-01-14 3:33 ` Greg KH
2013-01-14 8:12 ` Kevin Nguyen
2013-01-14 14:28 ` Greg KH
2013-01-15 2:09 ` Kevin Nguyen
2013-01-15 2:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115023029.GA6049@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=afelion@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).