From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller Date: Tue, 15 Jan 2013 18:50:28 -0800 Message-ID: <20130116025028.GA29056@kroah.com> References: <1355288826.30354.237.camel@bichao> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.19.201]:59089 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756106Ab3APCt3 (ORCPT ); Tue, 15 Jan 2013 21:49:29 -0500 Content-Disposition: inline In-Reply-To: <1355288826.30354.237.camel@bichao> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: chao bi Cc: Alan Cox , richardx.r.gorby@intel.com, jun.d.chen@intel.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Dec 12, 2012 at 01:07:06PM +0800, chao bi wrote: > > As protocol driver, IFX SPI driver initiate to setup SPI master with default > SPI word size as 16 bit/word, however, SPI master may not adopt this default > value due to SPI controller's capability, it might choose an available value by > itself and set it to spi_device.bits_per_word. In order to keep align with > Controller, IFX driver should make use of this value during SPI transfer, > but the default one. > > Signed-off-by: Chen Jun > Signed-off-by: channing > --- > drivers/tty/serial/ifx6x60.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c > index 675d94a..5919992 100644 > --- a/drivers/tty/serial/ifx6x60.c > +++ b/drivers/tty/serial/ifx6x60.c > @@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data) > ifx_dev->spi_xfer.cs_change = 0; > ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz; > /* ifx_dev->spi_xfer.speed_hz = 390625; */ > - ifx_dev->spi_xfer.bits_per_word = spi_bpw; > + ifx_dev->spi_xfer.bits_per_word = > + ifx_dev->spi_dev->bits_per_word; Please follow the proper coding style (hint, this isn't it.) thanks, greg k-h