From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Grant Edwards <grant.b.edwards@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: Curious about tty_port_operations drop() callback.
Date: Wed, 23 Jan 2013 14:38:15 +0000 [thread overview]
Message-ID: <20130123143815.0cecd29a@www.etchedpixels.co.uk> (raw)
In-Reply-To: <kdmfat$dt9$1@ger.gmane.org>
On Tue, 22 Jan 2013 16:38:54 +0000 (UTC)
Grant Edwards <grant.b.edwards@gmail.com> wrote:
> While testing/debugging the tty driver I've changed to use the
> tty_port_* helper functions, I noticed there are two
> tty_port_operation fields that I'm not providing: destruct() and
> drop(). There's an example of destruct() usage in the hvc driver and a
> comment in tty.h explaining when it's called, so that's fairly
> obvious.
>
> I haven't been able to figure out the purpose of the drop() callback.
> It's not used anywhere and there is no comment in tty.h hinting at its
> purpose.
It may well no longer be needed. If so then I'm all for its removal.
Alan
prev parent reply other threads:[~2013-01-23 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 16:38 Curious about tty_port_operations drop() callback Grant Edwards
2013-01-23 14:38 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123143815.0cecd29a@www.etchedpixels.co.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=grant.b.edwards@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).