From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: jslaby@suse.cz, linus.walleij@linaro.org,
anton.vorontsov@linaro.org, linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/2] tty: serial: remove __init on pl011 console ops
Date: Wed, 6 Feb 2013 11:52:19 +0000 [thread overview]
Message-ID: <20130206115219.GE17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1360151235-11980-1-git-send-email-haojian.zhuang@linaro.org>
On Wed, Feb 06, 2013 at 07:47:14PM +0800, Haojian Zhuang wrote:
> If uart driver is probed defer, console_setup will be called later
> after __init && __initdata sections destroyed. And amba_console isn't
> defined in __init or __initdata section. So we needn't define
> pl011_console_setup() && pl011_console_get_options() in __init section.
It sounds like there's a deeper problem here - if this driver being
deferred, why isn't it being retried after the pinctrl stuff gets
its driver registered?
We've had bugs in this deferred probing before, I wouldn't be surprised
if there's more... and we should not be "fixing" drivers because of bugs
elsewhere.
next prev parent reply other threads:[~2013-02-06 11:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:47 [PATCH 1/2] tty: serial: remove __init on pl011 console ops Haojian Zhuang
2013-02-06 11:47 ` [PATCH 2/2] tty: serial: use module_init on pl011_init Haojian Zhuang
2013-02-06 17:17 ` Linus Walleij
2013-02-06 11:52 ` Russell King - ARM Linux [this message]
2013-02-06 12:31 ` [PATCH 1/2] tty: serial: remove __init on pl011 console ops Haojian Zhuang
2013-02-06 16:31 ` Linus Walleij
2013-02-06 16:38 ` Russell King - ARM Linux
2013-02-06 16:46 ` Linus Walleij
2013-02-09 17:22 ` Haojian Zhuang
2013-02-09 22:31 ` Grant Likely
2013-02-09 22:41 ` Russell King - ARM Linux
2013-02-10 3:31 ` Haojian Zhuang
2013-02-13 21:21 ` Grant Likely
2013-02-13 21:04 ` Grant Likely
2013-02-13 22:52 ` Russell King - ARM Linux
2013-02-13 23:04 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206115219.GE17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alan@linux.intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@linaro.org \
--cc=jslaby@suse.cz \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox