From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v3 1/3] serial: sh-sci: Add OF support Date: Wed, 27 Feb 2013 18:04:57 +0900 Message-ID: <20130227090456.GA7936@verge.net.au> References: <1361898208-6683-1-git-send-email-hechtb+renesas@gmail.com> <20130227080742.GB21690@linux-sh.org> <20130227081954.GA30395@linux-sh.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm Cc: Paul Mundt , Bastian Hecht , linux-sh@vger.kernel.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Wed, Feb 27, 2013 at 05:26:57PM +0900, Magnus Damm wrote: > On Wed, Feb 27, 2013 at 5:19 PM, Paul Mundt wrote: > > On Wed, Feb 27, 2013 at 05:11:34PM +0900, Magnus Damm wrote: > >> On Wed, Feb 27, 2013 at 5:07 PM, Paul Mundt wrote: > >> > On Tue, Feb 26, 2013 at 11:03:26AM -0600, Bastian Hecht wrote: > >> >> We add the capabilty to probe Renesas SCI devices using Device Tree setup. > >> >> > >> >> Signed-off-by: Bastian Hecht > >> >> --- > >> >> v3: > >> >> - add remaining register layouts to bindings > >> >> - remove register set mapping sci_regtype_modes[] > >> >> - adapt renesas,regtype probing > >> >> > >> >> - add enums SCBRR_ALGO_INVALID and SCBRR_NR_ALGOS > >> >> - check renesas,scbrr-algo-id boundaries using new enums > >> >> > >> >> .../bindings/tty/serial/renesas,sci-serial.txt | 53 ++++++++ > >> >> drivers/tty/serial/sh-sci.c | 126 +++++++++++++++++++- > >> >> include/linux/serial_sci.h | 4 + > >> >> 3 files changed, 179 insertions(+), 4 deletions(-) > >> >> create mode 100644 Documentation/devicetree/bindings/tty/serial/renesas,sci-serial.txt > >> >> > >> > Looks good to me. > >> > > >> > Reviewed-by: Paul Mundt > >> > >> Thanks. Do you intend to merge this yourself at some point, or do you > >> have some other preferred way to deal with this? > >> > > I can merge it if you like, but then obviously the ARM patches will have > > to wait until that part is upstream. I assumed you would want them all > > grouped together, at which point I don't mind if it goes through some > > other tree. > > [Added Simon as CC] > > My personal preference would be that you (Paul) merge this patch by yourself: > [PATCH v3 1/3] serial: sh-sci: Add OF support > > I believe we can deal with the SoC bits easily afterwards. Simon may > however prefer to deal with it differently. > > Simon, how do you prefer to handle merge of DT support for the SCIF driver? I am fairly ambivalent. If Paul could merge this patch upstream in the v3.9-rc1~rc3 time frame then I can queue up the SoC portions for v3.10. Or alternatively I can queue up all three patches for v3.10. Either way the outcome should be much the same.