From: Greg KH <gregkh@linuxfoundation.org>
To: Karthik Manamcheri <karthik.manamcheri@gmail.com>
Cc: linux-serial@vger.kernel.org,
Karthik Manamcheri <karthik.manamcheri@ni.com>
Subject: Re: [PATCH] serial: 8250: Make SERIAL8250_CONFIG_RUNTIME_UARTS work correctly
Date: Thu, 28 Mar 2013 14:22:54 -0700 [thread overview]
Message-ID: <20130328212254.GA20051@kroah.com> (raw)
In-Reply-To: <1364502043-13018-1-git-send-email-karthik.manamcheri@ni.com>
On Thu, Mar 28, 2013 at 03:20:43PM -0500, Karthik Manamcheri wrote:
> Currently, if you set SERIAL8250_CONFIG_RUNTIME_UARTS
There is no such config option, please get it correct.
> to 0, you cannot get any working ports.
Isn't that on purpose? Why would you ever set that value to 0 and
expect things to work?
> This change will enable serial8250_register_port to successfully
> register a port even if SERIAL8250_CONFIG_RUNTIME_UARTS
> is 0. If you need legacy ports, you will set the
> SERIAL8250_CONFIG_RUNTIME_UARTS to the number of legacy
> ports you need created at boot time.
I don't understand, if you set the option to be 0, how can anything
work here?
greg k-h
next prev parent reply other threads:[~2013-03-28 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 20:20 [PATCH] serial: 8250: Make SERIAL8250_CONFIG_RUNTIME_UARTS work correctly Karthik Manamcheri
2013-03-28 21:22 ` Greg KH [this message]
[not found] ` <OFCAF9F7AE.C68748CA-ON86257B3C.00771424-86257B3C.00798499@ni.com>
2013-03-28 22:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328212254.GA20051@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=karthik.manamcheri@gmail.com \
--cc=karthik.manamcheri@ni.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox