From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] tty: serial: ralink: fix SERIAL_8250_RT288X dependency Date: Mon, 15 Apr 2013 11:15:27 -0700 Message-ID: <20130415181527.GA25341@kroah.com> References: <1365845973-16164-1-git-send-email-blogic@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:43034 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756082Ab3DOSPd (ORCPT ); Mon, 15 Apr 2013 14:15:33 -0400 Received: by mail-pa0-f54.google.com with SMTP id fa11so2693889pad.13 for ; Mon, 15 Apr 2013 11:15:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1365845973-16164-1-git-send-email-blogic@openwrt.org> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: John Crispin Cc: linux-mips@linux-mips.org, linux-serial@vger.kernel.org On Sat, Apr 13, 2013 at 11:39:32AM +0200, John Crispin wrote: > With every Ralink SoC that we add, we would need to extend the dependency. In > order to make life easier we make the symbol depend on MIPS & RALINK and then > select it from within arch/mips/ralink/. > > Signed-off-by: John Crispin > --- > > These 2 patches in this series should be merged via the mips tree. Patch 1/2 > requires an Ack from the tty maintainer. > > drivers/tty/serial/8250/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig > index 80fe91e..24ea3c8 100644 > --- a/drivers/tty/serial/8250/Kconfig > +++ b/drivers/tty/serial/8250/Kconfig > @@ -295,8 +295,8 @@ config SERIAL_8250_EM > If unsure, say N. > > config SERIAL_8250_RT288X > - bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support" > - depends on SERIAL_8250 && (SOC_RT288X || SOC_RT305X || SOC_RT3883) > + bool > + depends on SERIAL_8250 && MIPS && RALINK This patch doesn't create a select anywhere, so how can a user know what to do here? greg k-h