From: Shawn Guo <shawn.guo@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
'Jiri Slaby' <jslaby@suse.cz>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata()
Date: Tue, 7 May 2013 16:30:33 +0800 [thread overview]
Message-ID: <20130507083032.GM1749@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <008c01ce4af9$45e6f880$d1b4e980$@samsung.com>
On Tue, May 07, 2013 at 05:02:50PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/tty/serial/imx.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 147c9e1..3d17f5b 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1559,8 +1559,6 @@ static int serial_imx_remove(struct platform_device *pdev)
>
> pdata = pdev->dev.platform_data;
>
> - platform_set_drvdata(pdev, NULL);
> -
> uart_remove_one_port(&imx_reg, &sport->port);
>
> clk_disable_unprepare(sport->clk_per);
> --
> 1.7.2.5
>
>
prev parent reply other threads:[~2013-05-07 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 8:02 [PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 8:30 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507083032.GM1749@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox