From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v2] serial: sccnxp: Improve verify_port
Date: Tue, 14 May 2013 12:46:39 -0400 [thread overview]
Message-ID: <20130514164639.GA3686@kroah.com> (raw)
In-Reply-To: <1368549047.374871060@f159.mail.ru>
On Tue, May 14, 2013 at 08:30:47PM +0400, Alexander Shiyan wrote:
> > On Tue, May 14, 2013 at 07:59:11PM +0400, Alexander Shiyan wrote:
> > > The patch improves verify_port procedure by comparing the type of
> > > port and IRQ numbers simultaneously. This can be important in the
> > > case of multiple drivers SCCNXP in the system that are different IRQs.
> >
> > So this fixes a bug? Really?
>
> Only in theory.
How? It really doesn't look like you are doing anything here, except
rearranging the logic to look different, but yet do the same thing.
So again, why are you doing this?
greg k-h
next prev parent reply other threads:[~2013-05-14 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 15:59 [PATCH v2] serial: sccnxp: Improve verify_port Alexander Shiyan
2013-05-14 16:09 ` Greg Kroah-Hartman
2013-05-14 16:30 ` Re[2]: " Alexander Shiyan
2013-05-14 16:46 ` Greg Kroah-Hartman [this message]
2013-05-14 16:58 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514164639.GA3686@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).