Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Alessandro Rubini <rubini@gnudd.com>
To: linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, gregkh@linuxfoundation.org,
	jslaby@suse.cz, linux-serial@vger.kernel.org, x86@kernel.org,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	Chanho Min <chanho.min@lge.com>,
	Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
Subject: amba pl011: where to submit a fix for x86 builds
Date: Fri, 7 Jun 2013 11:38:54 +0200	[thread overview]
Message-ID: <20130607093854.GA3429@mail.gnudd.com> (raw)

Hello.
This is cc'd to $(get_maintainer.pl -f drivers/tty/serial/amba-pl011.c)
and x86 maintainers too.

While working on the pci-to-amba bridge driver (to be resubmitted in
the next days) I have to deal with the problem of pl011 not building,
after phys_to_page was introduced, by Chanho Min (Cc: here) in commit

   cb06ff1 ARM: PL011: Add support for Rx DMA buffer polling.

because x86 has no phys_to_page.

The fix I use is trivially this:

  -       sg_set_page(&sg->sg, phys_to_page(dma_addr),
  +       sg_set_page(&sg->sg, virt_to_page(sg->buf),

(virt_to_page is slower, but other sg_get_page() users do the same
and other solutions are more convoluted).

Shall I submit this to x86 with the pci-to-amba bridge series or to
arm/serial and then note the dependency when posting the bridge series?

thanks
/alessandro

             reply	other threads:[~2013-06-07  9:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07  9:38 Alessandro Rubini [this message]
2013-06-07  9:50 ` amba pl011: where to submit a fix for x86 builds Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607093854.GA3429@mail.gnudd.com \
    --to=rubini@gnudd.com \
    --cc=chanho.min@lge.com \
    --cc=giancarlo.asnaghi@st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox