From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] serial: imx: enable the clocks for console Date: Sun, 9 Jun 2013 10:26:28 -0700 Message-ID: <20130609172628.GA17829@kroah.com> References: <1370743279-15941-1-git-send-email-b32955@freescale.com> <20130609083409.GA32485@S2101-09.ap.freescale.net> <20130609130544.GC20780@S2101-09.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:50213 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184Ab3FIRZz (ORCPT ); Sun, 9 Jun 2013 13:25:55 -0400 Content-Disposition: inline In-Reply-To: <20130609130544.GC20780@S2101-09.ap.freescale.net> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Shawn Guo Cc: Huang Shijie , shc_work@mail.ru, festevam@gmail.com, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Sun, Jun 09, 2013 at 09:05:47PM +0800, Shawn Guo wrote: > On Sun, Jun 09, 2013 at 04:34:11PM +0800, Shawn Guo wrote: > > On Sun, Jun 09, 2013 at 10:01:19AM +0800, Huang Shijie wrote: > > > The console's clocks are disabled after the uart driver is probed. > > > It makes that we can see less log from the console now > > > (though we still can get all the log by the `dmesg`). > > > > > > So enable the clocks for console, and we can see all the log again. > > > > > > This patch also disables the sport->clk_per when we fail to enable > > > the sport->clk_ipg; > > > > > > Signed-off-by: Huang Shijie > > > > Tested-by: Shawn Guo > > Sorry. I have to take that back. > > Though it works fine with BusyBox, I'm getting the following warnings > when booting with an Ubuntu 13.04 rootfs, in which case imx_startup() > and imx_shutdown() will be called for a number of iterations. That > causes unbalanced clk_prepare_enable vs. clk_disable_unprepare, since > the clk_prepare_enable is under condition if (!uart_console(port)) in > imx_startup(), while clk_disable_unprepare in imx_shutdown() is not. I had just applied this to my tree, should I revert it because of this problem? thanks, greg k-h