Re: [PATCH 10/13] ARM: dts: Add initial device tree support for Exynos5420

[Mark Rutland <mark.rutland@arm.com>]

On Tue, Jun 11, 2013 at 02:35:38PM +0100, Chander Kashyap wrote:
> On 6 June 2013 22:04, Mark Rutland <mark.rutland@arm.com> wrote:
> > Hi,
> >
> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> new file mode 100644
> >> index 0000000..b14e775
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
> >> @@ -0,0 +1,40 @@
> >> +/*
> >> + * SAMSUNG SMDK5420 board device tree source
> >> + *
> >> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> >> + *           http://www.samsung.com
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License version 2 as
> >> + * published by the Free Software Foundation.
> >> +*/
> >> +
> >> +/dts-v1/;
> >> +/include/ "exynos5420.dtsi"
> >> +
> >> +/ {
> >> +     model = "Samsung SMDK5420 board based on EXYNOS5420";
> >> +     compatible = "samsung,smdk5420", "samsung,exynos5420";
> >> +
> >> +     memory {
> >> +             reg =   <0x20000000 0x10000000
> >> +                      0x30000000 0x10000000
> >> +                      0x40000000 0x10000000
> >> +                      0x50000000 0x10000000
> >> +                      0x60000000 0x10000000
> >> +                      0x70000000 0x10000000
> >> +                      0x80000000 0x10000000
> >> +                      0x90000000 0x10000000>;
> >> +     };
> >
> As there are only 28 bits for memory bank size in memory.h.
> Hence each bank is split into 256MB.

I don't think a kernel implementation choice should affect the dts.

If the kernel needs to carve up the memory, it should do it itself - it knows
what it needs. Splitting the banks manually as above is papering over the
problem.

Thanks,
Mark.