From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
Jamie Iles <jamie@jamieiles.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 2/4] tty/8250_dw: Add support for OCTEON UARTS.
Date: Thu, 20 Jun 2013 11:29:00 +0300 [thread overview]
Message-ID: <20130620082900.GB32331@xps8300> (raw)
In-Reply-To: <1371677849-23912-3-git-send-email-ddaney.cavm@gmail.com>
On Wed, Jun 19, 2013 at 02:37:27PM -0700, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> A few differences needed by OCTEON:
>
> o These are DWC UARTS, but have USR at a different offset.
>
> o Internal SoC buses require reading back from registers to maintain
> write ordering.
>
> o 8250 on OCTEON appears with 64-bit wide registers, so when using
> readb/writeb in big endian mode we have to adjust the membase to hit
> the proper part of the register.
>
> o No UCV register, so we hard code some properties.
>
> Because OCTEON doesn't have a UCV register, I change where
> dw8250_setup_port(), which reads the UCV, is called by pushing it in
> to the OF and ACPI probe functions, and move unchanged
> dw8250_setup_port() earlier in the file.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
--
heikki
next prev parent reply other threads:[~2013-06-20 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 21:37 [PATCH v2 0/4] MIPS/tty/8250: Use standard 8250 drivers for OCTEON David Daney
2013-06-19 21:37 ` [PATCH v2 1/4] MIPS: OCTEON: Set proper UART clock in internal device trees David Daney
2013-06-19 21:37 ` [PATCH v2 2/4] tty/8250_dw: Add support for OCTEON UARTS David Daney
2013-06-19 22:42 ` Arnd Bergmann
2013-06-20 8:29 ` Heikki Krogerus [this message]
2013-06-19 21:37 ` [PATCH v2 3/4] MIPS: OCTEON: Remove custom serial setup code David Daney
2013-06-19 21:37 ` [PATCH v2 4/4] MIPS: Update cavium_octeon_defconfig David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620082900.GB32331@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=arnd@arndb.de \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamie@jamieiles.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).