From: Mark Rutland <mark.rutland@arm.com>
To: Huang Shijie <b32955@freescale.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property
Date: Tue, 2 Jul 2013 10:56:45 +0100 [thread overview]
Message-ID: <20130702095645.GD31358@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1372746628-20092-4-git-send-email-b32955@freescale.com>
On Tue, Jul 02, 2013 at 07:30:26AM +0100, Huang Shijie wrote:
> The imx6 uart can supports the DMA, imx uart driver has added a new
> compatible property for the imx6 uart.
>
> In order to enable the DMA for some uart port in imx6, we rename the
> uart's compatible property to "fsl,imx6-uart".
Doesn't this change break using these dts with an older kernel? You
remove the "fsl,imx21-uart" string older kernels understand.
Given you already had "fsl,imx6q-uart" and "fsl,imx6sl-uart" strings,
would it not have made more sense to just add these to the driver?
Thanks,
Mark.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 10 +++++-----
> arch/arm/boot/dts/imx6sl.dtsi | 10 +++++-----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 0509344..d4ab0ee 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -179,7 +179,7 @@
> };
>
> uart1: serial@02020000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02020000 0x4000>;
> interrupts = <0 26 0x04>;
> clocks = <&clks 160>, <&clks 161>;
> @@ -787,7 +787,7 @@
> };
>
> uart2: serial@021e8000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x021e8000 0x4000>;
> interrupts = <0 27 0x04>;
> clocks = <&clks 160>, <&clks 161>;
> @@ -796,7 +796,7 @@
> };
>
> uart3: serial@021ec000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x021ec000 0x4000>;
> interrupts = <0 28 0x04>;
> clocks = <&clks 160>, <&clks 161>;
> @@ -805,7 +805,7 @@
> };
>
> uart4: serial@021f0000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x021f0000 0x4000>;
> interrupts = <0 29 0x04>;
> clocks = <&clks 160>, <&clks 161>;
> @@ -814,7 +814,7 @@
> };
>
> uart5: serial@021f4000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x021f4000 0x4000>;
> interrupts = <0 30 0x04>;
> clocks = <&clks 160>, <&clks 161>;
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 9138c67..ca1527f 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -152,7 +152,7 @@
> };
>
> uart5: serial@02018000 {
> - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02018000 0x4000>;
> interrupts = <0 30 0x04>;
> clocks = <&clks IMX6SL_CLK_UART>,
> @@ -162,7 +162,7 @@
> };
>
> uart1: serial@02020000 {
> - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02020000 0x4000>;
> interrupts = <0 26 0x04>;
> clocks = <&clks IMX6SL_CLK_UART>,
> @@ -172,7 +172,7 @@
> };
>
> uart2: serial@02024000 {
> - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02024000 0x4000>;
> interrupts = <0 27 0x04>;
> clocks = <&clks IMX6SL_CLK_UART>,
> @@ -209,7 +209,7 @@
> };
>
> uart3: serial@02034000 {
> - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02034000 0x4000>;
> interrupts = <0 28 0x04>;
> clocks = <&clks IMX6SL_CLK_UART>,
> @@ -219,7 +219,7 @@
> };
>
> uart4: serial@02038000 {
> - compatible = "fsl,imx6sl-uart", "fsl,imx21-uart";
> + compatible = "fsl,imx6-uart";
> reg = <0x02038000 0x4000>;
> interrupts = <0 29 0x04>;
> clocks = <&clks IMX6SL_CLK_UART>,
> --
> 1.7.1
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2013-07-02 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 6:30 [PATCH 0/5] serial: imx: add DMA support for imx6 Huang Shijie
2013-07-02 6:30 ` [PATCH 1/5] serial: imx: distinguish the imx6 uart from the others Huang Shijie
2013-07-03 1:48 ` Shawn Guo
2013-07-03 1:52 ` Shawn Guo
2013-07-03 2:17 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 2/5] serial: imx: add DMA support for imx6 Huang Shijie
2013-07-03 3:38 ` Shawn Guo
2013-07-03 5:20 ` Huang Shijie
2013-07-02 6:30 ` [PATCH 3/5] ARM: dts: imx6: rename the uart's compatible property Huang Shijie
2013-07-02 9:56 ` Mark Rutland [this message]
2013-07-02 10:43 ` Huang Shijie
2013-07-02 11:11 ` Mark Rutland
2013-07-03 2:15 ` Huang Shijie
2013-07-03 1:46 ` Shawn Guo
2013-07-02 6:30 ` [PATCH 4/5] ARM: dts: imx6: add dte pinctrl for uart2 Huang Shijie
2013-07-02 6:30 ` [PATCH 5/5] ARM: dts: enable the uart2 for imx6q-arm2 Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702095645.GD31358@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=b32955@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).