linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	Huang Shijie <b32955@freescale.com>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 4/6] ARM: dts: imx6q{dl}: fix the wrong RTS/CTS pad name
Date: Mon, 8 Jul 2013 08:50:04 +0100	[thread overview]
Message-ID: <20130708075004.GR24642@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20953.22066.706534.773272@ipc1.ka-ro>

On Sun, Jul 07, 2013 at 01:51:14PM +0200, Lothar Waßmann wrote:
> Hi,
> 
> Shawn Guo writes:
> > On Fri, Jul 05, 2013 at 02:12:30PM +0800, Huang Shijie wrote:
> > > There is something wrong with the RTS/CTS pads:
> > >   The RTS pad is assigned with the CTS's value;
> > >   while the CTS pad is assigned with the RTS's value.
> > > 
> > 
> > So basically, you are saying that select_input should be set up for CTS
> > rather than RTS.  It seems that the people who generated the macro got
> > the wrong input from developer.
> > 
> programming 'select_input' only makes sense for inputs, not outputs.
> Since CTS is an output signal, select_input only makes sense for the
> RTS function of the pads.

Note: If you are a DTE, then RTS is an output, CTS is an input.  If you
are a DCE, then RTS is an input and CTS is an output (normally on a
standard UART, you just swap the wiring for RTS and CTS but really that's
all that is going on.)  So swapping them in software should be acceptable
too, provided you're not having to disable any auto flow control facilities.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-07-08  7:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05  6:12 [PATCH v3 0/6] serial: imx: add DMA support for imx6 Huang Shijie
2013-07-05  6:12 ` [PATCH v3 1/6] serial: imx: distinguish the imx6q uart from the others Huang Shijie
2013-07-05  6:12 ` [PATCH v3 2/6] serial: imx: add DMA support for imx6q Huang Shijie
2013-07-05  6:12 ` [PATCH v3 3/6] ARM: dts: imx6sl: add "fsl,imx6q-uart" for uart compatible Huang Shijie
2013-07-05  6:12 ` [PATCH v3 4/6] ARM: dts: imx6q{dl}: fix the wrong RTS/CTS pad name Huang Shijie
2013-07-06  5:08   ` Shawn Guo
2013-07-07 11:51     ` Lothar Waßmann
2013-07-08  2:42       ` Shawn Guo
2013-07-08  6:31       ` Huang Shijie
2013-07-08  7:32         ` Lothar Waßmann
2013-07-08  8:54           ` Huang Shijie
2013-07-08  7:50       ` Russell King - ARM Linux [this message]
2013-07-08  8:03         ` Lothar Waßmann
2013-07-08  8:54         ` Huang Shijie
2013-07-05  6:12 ` [PATCH v3 5/6] ARM: dts: imx6q{dl}: add a DTE uart pinctrl for uart2 Huang Shijie
2013-07-05  6:12 ` [PATCH v3 6/6] ARM: dts: enable the uart2 for imx6q-arm2 Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130708075004.GR24642@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=LW@KARO-electronics.de \
    --cc=b32955@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).