* [PATCH] serial: imx: Use NULL as the last argument of add_preferred_console()
@ 2013-09-02 1:24 Fabio Estevam
2013-09-02 8:18 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2013-09-02 1:24 UTC (permalink / raw)
To: gregkh; +Cc: s.hauer, linux-serial, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Commit f7d2c0bbd (serial: i.MX: evaluate linux,stdout-path property) introduced
the following sparse warning:
drivers/tty/serial/imx.c:1916:77: warning: Using plain integer as NULL pointer
Pass NULL as the last argument of add_preferred_console() instead of zero.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/tty/serial/imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 2c13155..9a66dc5 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1913,7 +1913,8 @@ static int serial_imx_probe_dt(struct imx_port *sport,
sport->devdata = of_id->data;
if (of_device_is_stdout_path(np))
- add_preferred_console(imx_reg.cons->name, sport->port.line, 0);
+ add_preferred_console(imx_reg.cons->name, sport->port.line,
+ NULL);
return 0;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: imx: Use NULL as the last argument of add_preferred_console()
2013-09-02 1:24 [PATCH] serial: imx: Use NULL as the last argument of add_preferred_console() Fabio Estevam
@ 2013-09-02 8:18 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-09-02 8:18 UTC (permalink / raw)
To: Fabio Estevam; +Cc: gregkh, linux-serial, Fabio Estevam
On Sun, Sep 01, 2013 at 10:24:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit f7d2c0bbd (serial: i.MX: evaluate linux,stdout-path property) introduced
> the following sparse warning:
>
> drivers/tty/serial/imx.c:1916:77: warning: Using plain integer as NULL pointer
>
> Pass NULL as the last argument of add_preferred_console() instead of zero.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/tty/serial/imx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 2c13155..9a66dc5 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1913,7 +1913,8 @@ static int serial_imx_probe_dt(struct imx_port *sport,
> sport->devdata = of_id->data;
>
> if (of_device_is_stdout_path(np))
> - add_preferred_console(imx_reg.cons->name, sport->port.line, 0);
> + add_preferred_console(imx_reg.cons->name, sport->port.line,
> + NULL);
>
> return 0;
> }
> --
> 1.8.1.2
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-02 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 1:24 [PATCH] serial: imx: Use NULL as the last argument of add_preferred_console() Fabio Estevam
2013-09-02 8:18 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).