From: Sascha Hauer <s.hauer@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: Commit f7d2c0bb (serial: i.MX: evaluate linux,stdout-path property) and resulting build errors
Date: Sun, 6 Oct 2013 13:09:56 +0200 [thread overview]
Message-ID: <20131006110956.GM30088@pengutronix.de> (raw)
In-Reply-To: <20131003184445.GH8901@kroah.com>
On Thu, Oct 03, 2013 at 11:44:45AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Oct 02, 2013 at 09:56:11PM -0700, Guenter Roeck wrote:
> > Hi all,
> >
> > Commit f7d2c0bbdb (serial: i.MX: evaluate linux,stdout-path property) adds a
> > call to add_preferred_console() into drivers/tty/serial/imx.c. The file can be
> > built as module, yet add_preferred_console() is not exported on any platform.
> > This is one reason why arm:allmodconfig fails to build on the upstream kernel.
> >
> > What is the best solution ? Should imx.c not be buildable as module anymore ?
>
> Sascha, I'll have to revert this patch unless you wish to fix it in a
> different way?
Do you think exporting add_preferred_console() would be acceptable? If
yes, that would be my preferred solution.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-10-06 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 4:56 Commit f7d2c0bb (serial: i.MX: evaluate linux,stdout-path property) and resulting build errors Guenter Roeck
2013-10-03 18:44 ` Greg Kroah-Hartman
2013-10-06 11:09 ` Sascha Hauer [this message]
2013-10-06 13:42 ` Greg Kroah-Hartman
2013-10-06 14:37 ` Guenter Roeck
2013-10-06 19:15 ` Greg Kroah-Hartman
2013-10-07 6:49 ` Sascha Hauer
2013-10-07 10:56 ` Guenter Roeck
2013-10-07 12:31 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131006110956.GM30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).