From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-serial@vger.kernel.org, kernel@pengutronix.de
Subject: Re: base baud reporting strange on efm32
Date: Mon, 7 Oct 2013 09:28:24 +0200 [thread overview]
Message-ID: <20131007072824.GJ10079@pengutronix.de> (raw)
In-Reply-To: <20131007072149.GB4755@kroah.com>
On Mon, Oct 07, 2013 at 12:21:49AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Oct 07, 2013 at 09:03:06AM +0200, Uwe Kleine-König wrote:
> > Hello Kees, hello Greg,
> >
> > since commit
> > 7d12b97 (serial: report base_baud after initialization)
> > my efm32 machine says during startup:
> > 4000e400.uart: ttyefm4 at MMIO 0x4000e400 (irq = 25, base_baud = 0) is a efm32-uart
> >
> > Is this "= 0" expected or is there something wrong in the driver?
>
> Does the hardware work properly? That's the best test of this, right?
Yes, it works fine. Still I wonder if there is a problem that the driver
doesn't fill in port.uartclk early enough. In the efm32-uart driver (i.e.
drivers/tty/serial/efm32-uart.c) this member is only assigned to in
.startup.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-07 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 7:03 base baud reporting strange on efm32 Uwe Kleine-König
2013-10-07 7:21 ` Greg Kroah-Hartman
2013-10-07 7:28 ` Uwe Kleine-König [this message]
2013-10-07 20:46 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007072824.GJ10079@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).