Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Jiří Prchal" <jiri.prchal@aksignal.cz>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, nicolas.ferre@atmel.com
Subject: Re: [PATCH] serial: prepare for 9bit data
Date: Fri, 11 Oct 2013 08:36:40 -0700	[thread overview]
Message-ID: <20131011153640.GB14715@kroah.com> (raw)
In-Reply-To: <5257E804.6020800@aksignal.cz>

On Fri, Oct 11, 2013 at 01:59:00PM +0200, Jiří Prchal wrote:
> 
> 
> Dne 27.9.2013 00:47, Greg KH napsal(a):
> >On Mon, Sep 23, 2013 at 02:07:32PM +0200, Jiri Prchal wrote:
> >>This patch adds 9bit data possibility for serial_core. Please confirm that I did it right way at right place. I'll make atmel_serial driver for 9bit data later.
> >
> >Please wrap your lines properly.
> >
> >I'd rather wait to add this type of patch _after_ you have tested it and
> >verified that your driver works, and take that patch at the same time.
> >
> >Otherwise, this is just added cruft that no one is using, and I'd have
> >to remove it :)
> No one is using it because it is NOT implemented.

Then implement it.

> Try to search internet for "9bit serial" to see how many people like to use it.

Again, then implement it, I can't add code to the kernel that no one
uses, that would be cruft and be deleted, right?

> But I probably not bother to do it and I'll try some tricks with parity.
> As many others.

Why not just implement it, then it can stay, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2013-10-11 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 12:07 [PATCH] serial: prepare for 9bit data Jiri Prchal
2013-09-26 22:47 ` Greg KH
2013-10-11 11:59   ` Jiří Prchal
2013-10-11 15:36     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011153640.GB14715@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jiri.prchal@aksignal.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox